[sanitizers] asan_globals GN option

[sanitizers] asan_globals GN option

Detect overflow/underflow for global objects.
Enabled by default with asan, except for Android & Mac.

Committed: https://crrev.com/da5892e6e7d244252840ac929e63e446aef2397b
Cr-Commit-Position: refs/heads/master@{#404918}

[aizatsky, 2016-07-07 20:19:04]

aizatsky@chromium.org changed reviewers:
+ brettw@chromium.org

[aizatsky, 2016-07-11 21:24:33]

ping

[brettw, 2016-07-11 22:32:55]

LGTM, but can you write a more complete CL description?

https://codereview.chromium.org/2130893002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2130893002/diff/20001/build/config/sanitizers...
build/config/sanitizers/BUILD.gn:226: # TODO(GYP): deal with mac_bundles.
This comment about mac makes no sense to me now and I can't even tell what it
was referring to. Can you just delete it?

[aizatsky, 2016-07-12 20:37:21]

Description was changed from

==========
[sanitizers] asan_globals GN option

BUG=
==========

to

==========
[sanitizers] asan_globals GN option


Detect overflow/underflow for global objects. Enabled by default when asan is
enabled, except for Android & Mac.
==========

[aizatsky, 2016-07-12 20:38:17]

Description was changed from

==========
[sanitizers] asan_globals GN option


Detect overflow/underflow for global objects. Enabled by default when asan is
enabled, except for Android & Mac.
==========

to

==========
[sanitizers] asan_globals GN option


Detect overflow/underflow for global objects. 
Enabled by default with asan, except for Android & Mac.
==========

[aizatsky, 2016-07-12 20:39:16]

Description was changed from

==========
[sanitizers] asan_globals GN option


Detect overflow/underflow for global objects. 
Enabled by default with asan, except for Android & Mac.
==========

to

==========
[sanitizers] asan_globals GN option

Detect overflow/underflow for global objects. 
Enabled by default with asan, except for Android & Mac.
==========

[aizatsky, 2016-07-12 20:39:30]

thanks.

https://codereview.chromium.org/2130893002/diff/20001/build/config/sanitizers...
File build/config/sanitizers/BUILD.gn (right):

https://codereview.chromium.org/2130893002/diff/20001/build/config/sanitizers...
build/config/sanitizers/BUILD.gn:226: # TODO(GYP): deal with mac_bundles.
On 2016/07/11 at 22:32:55, brettw (ping after 24h) wrote:
> This comment about mac makes no sense to me now and I can't even tell what it
was referring to. Can you just delete it?

done.

[aizatsky, 2016-07-12 20:39:34]

The CQ bit was checked by aizatsky@chromium.org

[aizatsky, 2016-07-12 20:39:34]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2130893002/#ps40001
(title: "nits")

[commit-bot: I haz the power, 2016-07-12 20:41:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:38:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-13 02:39:04]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 02:41:21]

Description was changed from

==========
[sanitizers] asan_globals GN option

Detect overflow/underflow for global objects. 
Enabled by default with asan, except for Android & Mac.
==========

to

==========
[sanitizers] asan_globals GN option

Detect overflow/underflow for global objects.
Enabled by default with asan, except for Android & Mac.

Committed: https://crrev.com/da5892e6e7d244252840ac929e63e446aef2397b
Cr-Commit-Position: refs/heads/master@{#404918}
==========

[commit-bot: I haz the power, 2016-07-13 02:41:22]

Patchset 3 (id:??) landed as
https://crrev.com/da5892e6e7d244252840ac929e63e446aef2397b
Cr-Commit-Position: refs/heads/master@{#404918}