Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2130843002: Fix crash with sticky html element. (Closed)

Created:
4 years, 5 months ago by flackr
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash with sticky html element. Making the html element sticky was attempting to resolve the html's container's padding against it's container logical width to remove it from the sticky region causing a crash. BUG=626156 TEST=fast/css/sticky/sticky-html-crash.html Committed: https://crrev.com/b36f6a3818c30c1d450028cfcd6cf02141642230 Cr-Commit-Position: refs/heads/master@{#404301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/sticky/sticky-html-crash.html View 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/css/sticky/sticky-html-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
flackr
PTAL, thanks! I'm not sure if the layout view can have padding but resolving against ...
4 years, 5 months ago (2016-07-07 18:31:44 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-07-07 23:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130843002/1
4 years, 5 months ago (2016-07-07 23:43:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 01:30:08 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 01:30:11 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 01:32:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b36f6a3818c30c1d450028cfcd6cf02141642230
Cr-Commit-Position: refs/heads/master@{#404301}

Powered by Google App Engine
This is Rietveld 408576698