Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2130823002: Refactor print-stale-test-expectations-entries. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, nainar
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor print-stale-test-expectations-entries. In this CL: - Extract a function check_expectations_line - Extract a function write_csv - Remove unused imports - Print errors to stderr and include bug links in message BUG=597797 Committed: https://crrev.com/75c5d0912c9c8052ec04aa66a056f346394e8abe Cr-Commit-Position: refs/heads/master@{#404707}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M third_party/WebKit/Tools/Scripts/print-stale-test-expectations-entries View 1 2 2 chunks +58 lines, -40 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
qyearsley
4 years, 5 months ago (2016-07-07 18:27:21 UTC) #4
nainar
lgtm
4 years, 5 months ago (2016-07-11 02:03:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130823002/40001
4 years, 5 months ago (2016-07-11 17:43:01 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-11 19:22:50 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 19:23:04 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/75c5d0912c9c8052ec04aa66a056f346394e8abe Cr-Commit-Position: refs/heads/master@{#404707}
4 years, 5 months ago (2016-07-11 19:25:52 UTC) #12
Dirk Pranke
4 years, 4 months ago (2016-08-09 03:41:48 UTC) #13
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698