Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2130813002: [iOS] Remove conversion of .strings to binary1 by copy_bundle_data tool. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Remove conversion of .strings to binary1 by copy_bundle_data tool. All .strings files that need to be in binary1 format are now converted by using the "bundle_data_strings" template so the conversion can be remove from "copy_bundle_data" tool. BUG=625578 Committed: https://crrev.com/f52c49dc18851aaf7ca4f3a78b5312350193f5ba Cr-Commit-Position: refs/heads/master@{#404621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-07 16:09:51 UTC) #2
Robert Sesek
LGTM. Thanks for the cleanup!
4 years, 5 months ago (2016-07-07 17:28:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130813002/1
4 years, 5 months ago (2016-07-08 07:57:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/214167)
4 years, 5 months ago (2016-07-08 08:06:59 UTC) #7
sdefresne
Dirk can you give OWNERS review?
4 years, 5 months ago (2016-07-08 09:17:59 UTC) #9
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-08 19:42:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130813002/1
4 years, 5 months ago (2016-07-11 08:29:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 09:27:09 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 09:27:11 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 09:28:38 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f52c49dc18851aaf7ca4f3a78b5312350193f5ba
Cr-Commit-Position: refs/heads/master@{#404621}

Powered by Google App Engine
This is Rietveld 408576698