chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm - Issue 21308002: Update Mac notification tray behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm

Issue 21308002: Update Mac notification tray behavior. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix mac tests. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm ('k') | ui/message_center/cocoa/status_item_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm

diff --git a/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm b/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm

index a0c6cb06ed12c7f0d239b8d1605974ddc66acc94..57008c0d345b5d61086ff3645121389e4fe9bc90 100644

--- a/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm

+++ b/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm

@@ -38,7 +38,7 @@ class MessageCenterTrayBridgeTest : public ui::CocoaTest {

scoped_ptr<MessageCenterTrayBridge> bridge_;

};

-TEST_F(MessageCenterTrayBridgeTest, StatusItemOnlyWithNotifications) {

+TEST_F(MessageCenterTrayBridgeTest, StatusItemOnlyAfterFirstNotification) {

EXPECT_FALSE(status_item());

message_center::RichNotificationData data;

@@ -65,5 +65,5 @@ TEST_F(MessageCenterTrayBridgeTest, StatusItemOnlyWithNotifications) {

base::RunLoop().RunUntilIdle();

- EXPECT_FALSE(status_item());

+ EXPECT_TRUE(status_item());

}

« no previous file with comments | « chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.mm ('k') | ui/message_center/cocoa/status_item_view.h » ('j') | no next file with comments »