Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2130793003: Mac: Use unique output path for compile_xibs template in GN (Closed)

Created:
4 years, 5 months ago by Marshall
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Use unique output path for compile_xibs template in GN BUG=623237 R=rsesek@chromium.org Committed: https://crrev.com/2b273ced692cd454d1d2b9b6ff8ac9bf97754ce2 Cr-Commit-Position: refs/heads/master@{#404416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M build/config/mac/base_rules.gni View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marshall
Please review.
4 years, 5 months ago (2016-07-07 21:11:42 UTC) #1
Robert Sesek
lgtm
4 years, 5 months ago (2016-07-07 22:37:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130793003/1
4 years, 5 months ago (2016-07-08 15:20:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 16:49:32 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 16:52:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b273ced692cd454d1d2b9b6ff8ac9bf97754ce2
Cr-Commit-Position: refs/heads/master@{#404416}

Powered by Google App Engine
This is Rietveld 408576698