Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2130783002:
Revert of Disable WebRTC tests that are flaky under Dr. Memory. (Closed)
|
Created:
4 years, 5 months ago by perkj_chrome Modified:
4 years, 4 months ago Reviewers:
phoglund_chromium CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ )
Reason for revert:
I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out.
WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed.
Original issue's description:
> Disable WebRTC tests that are flaky under Dr. Memory.
>
> WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb
> WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID
>
> BUG=622085
> TBR=mcasas@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9f85283f12969
TBR=mcasas@chromium.org,reillyg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622085
Committed: https://crrev.com/b8116d5762db75f69882073b085aa73eac4423c9
Cr-Commit-Position: refs/heads/master@{#412190}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Created Revert of Disable WebRTC tests that are flaky under Dr. Memory.
On 2016/07/07 12:48:49, perkj_chrome wrote: > Created Revert of Disable WebRTC tests that are flaky under Dr. Memory. Wait, are you relanding just to see if these tests are still flaky or do you have a plan...?
Description was changed from ========== Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: Creating a revert patchset to run on drmemory try-bots. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG=622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9... TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622085 ========== to ========== Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out. WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG=622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9... TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622085 ==========
perkj@chromium.org changed reviewers: + phoglund@chromium.org - mcasas@chromium.org, reillyg@chromium.org
The CQ bit was checked by perkj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
phoglund, I have tested these tests at home without seeing them time out or fail. I would like to try to re-enable them an see how it goes.
lgtm
The CQ bit was unchecked by perkj@chromium.org
The CQ bit was checked by perkj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by perkj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out. WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG=622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9... TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622085 ========== to ========== Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out. WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG=622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9... TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622085 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out. WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG=622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9... TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622085 ========== to ========== Revert of Disable WebRTC tests that are flaky under Dr. Memory. (patchset #1 id:1 of https://codereview.chromium.org/2081423003/ ) Reason for revert: I have tested both tests a couple of time under dr memory full locally without seeing them fail or time out. WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID has been updated and not seemed to flake since https://codereview.chromium.org/2122153002/ was landed. Original issue's description: > Disable WebRTC tests that are flaky under Dr. Memory. > > WebRtcGetUserMediaBrowserTest.AudioInIFrameAndCloseInSuccessCb > WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID > > BUG=622085 > TBR=mcasas@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/3d07cfa01225f3e70ca9a2f94ba9... TBR=mcasas@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=622085 Committed: https://crrev.com/b8116d5762db75f69882073b085aa73eac4423c9 Cr-Commit-Position: refs/heads/master@{#412190} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b8116d5762db75f69882073b085aa73eac4423c9 Cr-Commit-Position: refs/heads/master@{#412190} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
