Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2130773002: Revert of Don't preload scripts with invalid type/language attributes (Closed)

Created:
4 years, 5 months ago by Charlie Harrison
Modified:
4 years, 5 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't preload scripts with invalid type/language attributes (patchset #5 id:80001 of https://codereview.chromium.org/2099853002/ ) Reason for revert: Some compat risk for this change was brought up. Going to send a note to blink-dev before re-landing. Original issue's description: > Don't preload scripts with invalid type/language attributes > > This patch keeps track of a script tag's type and language attributes, > and gates preloading if they are invalid. This aligns the preload scanner's > policy with the ScriptLoader's policy. > > BUG=623109 > > Committed: https://crrev.com/23f4df7587f338837a709afb192900102584fc0a > Cr-Commit-Position: refs/heads/master@{#403182} TBR=yoav@yoav.ws # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623109 Committed: https://crrev.com/a825f90e8fdbd9e41bd2dcafffa88662fb50878f Cr-Commit-Position: refs/heads/master@{#404153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -69 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 4 chunks +32 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 5 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Charlie Harrison
Created Revert of Don't preload scripts with invalid type/language attributes
4 years, 5 months ago (2016-07-07 12:08:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130773002/1
4 years, 5 months ago (2016-07-07 12:08:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 13:58:53 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 13:58:54 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a825f90e8fdbd9e41bd2dcafffa88662fb50878f Cr-Commit-Position: refs/heads/master@{#404153}
4 years, 5 months ago (2016-07-07 14:01:55 UTC) #7
Yoav Weiss
4 years, 5 months ago (2016-07-07 14:32:26 UTC) #8
Message was sent while issue was closed.
On 2016/07/07 14:01:55, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a825f90e8fdbd9e41bd2dcafffa88662fb50878f
> Cr-Commit-Position: refs/heads/master@{#404153}

LGTM

Powered by Google App Engine
This is Rietveld 408576698