Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2130763003: ash: Fix app list button always activated regression (Closed)

Created:
4 years, 5 months ago by xiyuan
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, mohsen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Fix app list button always activated regression BUG=625583 Committed: https://crrev.com/b0531d0c52a82a5afd38cdc7d2cea05a1aa2f39c Cr-Commit-Position: refs/heads/master@{#404206}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove {} for one-line branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ash/shelf/app_list_button.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
xiyuan
4 years, 5 months ago (2016-07-07 17:17:02 UTC) #3
James Cook
+mohsen as FYI LGTM
4 years, 5 months ago (2016-07-07 17:33:19 UTC) #4
James Cook
https://codereview.chromium.org/2130763003/diff/1/ash/shelf/app_list_button.cc File ash/shelf/app_list_button.cc (right): https://codereview.chromium.org/2130763003/diff/1/ash/shelf/app_list_button.cc#newcode61 ash/shelf/app_list_button.cc:61: } else { nit: } { not needed
4 years, 5 months ago (2016-07-07 17:34:26 UTC) #5
xiyuan
https://codereview.chromium.org/2130763003/diff/1/ash/shelf/app_list_button.cc File ash/shelf/app_list_button.cc (right): https://codereview.chromium.org/2130763003/diff/1/ash/shelf/app_list_button.cc#newcode61 ash/shelf/app_list_button.cc:61: } else { On 2016/07/07 17:34:26, James Cook wrote: ...
4 years, 5 months ago (2016-07-07 17:38:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130763003/20001
4 years, 5 months ago (2016-07-07 17:40:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 19:17:42 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 19:17:53 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 19:19:31 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0531d0c52a82a5afd38cdc7d2cea05a1aa2f39c
Cr-Commit-Position: refs/heads/master@{#404206}

Powered by Google App Engine
This is Rietveld 408576698