Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2130753004: Add renderer launch count to stability metrics. (Closed)

Created:
4 years, 5 months ago by Will Harris
Modified:
4 years, 5 months ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add renderer launch count to stability metrics. This will make it possible to have a more meaningful measure of true extension renderer stability as currently there is no denominator that can be used for normalization of extension stability. Desktop/Android only. BUG=621120 Committed: https://crrev.com/86b6c8ce661bf08b2650bf35bc96d79600095d80 Cr-Commit-Position: refs/heads/master@{#405851}

Patch Set 1 #

Patch Set 2 : do not report on chromecast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -6 lines) Patch
M chrome/browser/metrics/chrome_stability_metrics_provider.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M components/metrics/metrics_pref_names.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/metrics/metrics_pref_names.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/metrics/proto/system_profile.proto View 2 chunks +7 lines, -5 lines 0 comments Download
M components/metrics/stability_metrics_helper.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/metrics/stability_metrics_helper.cc View 5 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Will Harris
PTAL. Other CLs in google3-land will add the fields to the proto and also land ...
4 years, 5 months ago (2016-07-07 21:23:09 UTC) #4
Alexei Svitkine (slow)
Looks great! Please start the google3 CL review since we need that to land before ...
4 years, 5 months ago (2016-07-08 18:47:10 UTC) #5
Will Harris
ping; the code in google3 has landed.
4 years, 5 months ago (2016-07-15 16:58:37 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 5 months ago (2016-07-15 17:45:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130753004/20001
4 years, 5 months ago (2016-07-15 17:45:35 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/221929)
4 years, 5 months ago (2016-07-15 19:08:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130753004/20001
4 years, 5 months ago (2016-07-15 20:13:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 20:48:56 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 20:49:16 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 20:50:25 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86b6c8ce661bf08b2650bf35bc96d79600095d80
Cr-Commit-Position: refs/heads/master@{#405851}

Powered by Google App Engine
This is Rietveld 408576698