third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-length-viewport-units-interpolation.html - Issue 2130753003: Support viewport units for SVG Length animations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-length-viewport-units-interpolation.html

Issue 2130753003: Support viewport units for SVG Length animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp » ('j') | third_party/WebKit/Source/core/animation/SVGLengthInterpolationType.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <template id="target-template">

	5 <svg width="200px" height="300px" viewBox="0 0 1500 1000">

	6 <rect class="target" x="10" y="10" width="10" height="10" />

	7 </svg>

	8 </template>

	9 <script src="resources/interpolation-test.js"></script>

	10 <script>

	11 'use strict';

	12 assertAttributeInterpolation({

	13 property: 'width',
	fs 2016/07/08 11:14:03 I believe the common "structure" of this test dire I believe the common "structure" of this test directory is to group/test per attribute (property), so by that standard this would go in svg-width-... (and possibly in other files as well, the animation people will know better what they prefer) suzyh_UTC10 (ex-contributor) 2016/07/11 05:56:34 Yes, please move these tests into svg-width-interp Show quoted text On 2016/07/08 at 11:14:03, fs (ooo to July 18) wrote: > I believe the common "structure" of this test directory is to group/test per attribute (property), so by that standard this would go in svg-width-... (and possibly in other files as well, the animation people will know better what they prefer) Yes, please move these tests into svg-width-interpolation.html. Please also add a couple of tests that use these units where the 'from' and 'to' values use different units, as done in that file and others.
	14 from: '1vw',

	15 to: '6vw'

	16 }, [

	17 {at: -0.4, is: '0vw'},

	18 {at: 0, is: '1vw'},

	19 {at: 0.2, is: '2vw'},

	20 {at: 0.6, is: '4vw'},

	21 {at: 1, is: '6vw'},

	22 {at: 1.4, is: '8vw'}

	23 ]);

	24 assertAttributeInterpolation({

	25 property: 'width',

	26 from: '1vh',

	27 to: '6vh'

	28 }, [

	29 {at: -0.4, is: '0vh'},

	30 {at: 0, is: '1vh'},

	31 {at: 0.2, is: '2vh'},

	32 {at: 0.6, is: '4vh'},

	33 {at: 1, is: '6vh'},

	34 {at: 1.4, is: '8vh'}

	35 ]);

	36 assertAttributeInterpolation({

	37 property: 'width',

	38 from: '1vmin',

	39 to: '6vmin'

	40 }, [

	41 {at: -0.4, is: '0vmin'},

	42 {at: 0, is: '1vmin'},

	43 {at: 0.2, is: '2vmin'},

	44 {at: 0.6, is: '4vmin'},

	45 {at: 1, is: '6vmin'},

	46 {at: 1.4, is: '8vmin'}

	47 ]);

	48 assertAttributeInterpolation({

	49 property: 'width',

	50 from: '1vmax',

	51 to: '6vmax'

	52 }, [

	53 {at: -0.4, is: '0vmax'},

	54 {at: 0, is: '1vmax'},

	55 {at: 0.2, is: '2vmax'},

	56 {at: 0.6, is: '4vmax'},

	57 {at: 1, is: '6vmax'},

	58 {at: 1.4, is: '8vmax'}

	59 ]);

	60 </script>

	61 </body>

	62 </html>

OLD	NEW