Made setting lowbox token a warning.

content/common/sandbox_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/sandbox_win.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 779 matching lines @@
   policy->SetStdoutHandle(GetStdHandle(STD_OUTPUT_HANDLE));
   policy->SetStderrHandle(GetStdHandle(STD_ERROR_HANDLE));
 #endif
 
   if (!delegate->PreSpawnTarget(policy))
     return sandbox::SBOX_ERROR_DELEGATE_PRE_SPAWN;
 
   TRACE_EVENT_BEGIN0("startup", "StartProcessWithAccess::LAUNCHPROCESS");
 
   PROCESS_INFORMATION temp_process_info = {};
-  result = g_broker_services->SpawnTarget(
-      cmd_line->GetProgram().value().c_str(),
-      cmd_line->GetCommandLineString().c_str(), policy, &temp_process_info);
+  sandbox::ResultCode last_warning = sandbox::SBOX_ALL_OK;
+  result =
+      g_broker_services->SpawnTarget(cmd_line->GetProgram().value().c_str(),
+                                     cmd_line->GetCommandLineString().c_str(),
+                                     policy, &last_warning, &temp_process_info);
   DWORD last_error = ::GetLastError();

[Will Harris, 2016/07/12 16:10:59]

Seems anachronistic to pass the last_error by SetLastError() and GetLastError()
but pass last_warning via param, I wonder if this code could be changed in a
future CL.

   base::win::ScopedProcessInformation target(temp_process_info);
 
   TRACE_EVENT_END0("startup", "StartProcessWithAccess::LAUNCHPROCESS");
 
   if (sandbox::SBOX_ALL_OK != result) {
     UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Launch.Error", last_error);
     if (result == sandbox::SBOX_ERROR_GENERIC)
       DPLOG(ERROR) << "Failed to launch process";
     else
       DLOG(ERROR) << "Failed to launch process. Error: " << result;
 
     return result;
   }
 
+  if (sandbox::SBOX_ALL_OK != last_warning) {
+    UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Launch.WarningResultCode",

[Will Harris, 2016/07/12 16:10:59]

it might be an idea to always log this first histogram even when last_warning is
SBOX_ALL_OK then we get an accurate bucket percentage for each type.

+                                last_warning);
+    UMA_HISTOGRAM_SPARSE_SLOWLY("Process.Sandbox.Launch.Warning", last_error);
+  }
+
   delegate->PostSpawnTarget(target.process_handle());
 
   CHECK(ResumeThread(target.thread_handle()) != static_cast<DWORD>(-1));
   *process = base::Process(target.TakeProcessHandle());
   return sandbox::SBOX_ALL_OK;
 }
 
 }  // namespace content