Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2130743002: Convert .strings to binary before declaring bundle_data. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
jif, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert .strings to binary before declaring bundle_data. Add a template "bundle_data_strings" to convert a .strings file to binary1 property list format and declare it in a bundle_data target (similar to "bundle_data_xib" template). This is added in preparation of removing the automatic conversion of .strings file to binary1 format by the "copy_bundle_data" tool in build/toolchain/mac/BUILD.gn. There are no client upstream yet. BUG=625578 Committed: https://crrev.com/02416e8ab9a11f44eba47d269cd0aa5fb843895b Cr-Commit-Position: refs/heads/master@{#404142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M build/config/ios/rules.gni View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-07 09:45:15 UTC) #2
jif
I'm not the right person to review this.
4 years, 5 months ago (2016-07-07 12:05:22 UTC) #3
jif
however, it LGTM
4 years, 5 months ago (2016-07-07 12:10:54 UTC) #4
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-07 12:18:08 UTC) #6
justincohen
lgtm
4 years, 5 months ago (2016-07-07 12:20:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130743002/1
4 years, 5 months ago (2016-07-07 12:20:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 13:05:16 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 13:06:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02416e8ab9a11f44eba47d269cd0aa5fb843895b
Cr-Commit-Position: refs/heads/master@{#404142}

Powered by Google App Engine
This is Rietveld 408576698