[HttpStreamParser]: Flush buffers as soon as request is sent.

[HttpStreamParser]: Flush buffers as soon as request is sent.

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073
Committed: https://crrev.com/a4fc935d2fde3df3a7bb7d451b4a58f048ee225f
Cr-Commit-Position: refs/heads/master@{#405128}

[maksims (do not use this acc), 2016-07-07 12:23:16]

Description was changed from

==========
memory

BUG=
==========

to

==========
[HttpStreamParser]: Flush buffers as soon as request is sent.

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073
==========

[maksims (do not use this acc), 2016-07-08 07:14:13]

maksim.sisov@intel.com changed reviewers:
+ eroman@chromium.org, mariakhomenko@chromium.org, mmenke@chromium.org

[maksims (do not use this acc), 2016-07-08 10:56:15]

ptal

[mmenke, 2016-07-11 15:15:35]

https://codereview.chromium.org/2130733003/diff/1/net/http/http_stream_parser.cc
File net/http/http_stream_parser.cc (right):

https://codereview.chromium.org/2130733003/diff/1/net/http/http_stream_parser...
net/http/http_stream_parser.cc:477: // act like the request was successfully
sent.
Missed a spot.

https://codereview.chromium.org/2130733003/diff/1/net/http/http_stream_parser...
net/http/http_stream_parser.cc:477: // act like the request was successfully
sent.
I'd suggest adding a new state, DO_SEND_REQUEST_COMPLETE, and have it be the
only method to call FlushBuffers().

Also, I'd add DCHECKs in DoLoop, after all the other DoSend cases, to make sure
io_state_ is not NONE, to make sure we always go through the new state.  I'd
also add DCHECKs in HttpStreamParser::Read, to make sure the relevant fields are
empty.  Sound good?

https://codereview.chromium.org/2130733003/diff/1/net/http/http_stream_parser...
net/http/http_stream_parser.cc:1197: if (request_headers_)
None of these ifs are necessary - refptrs have identical null checks when you
clear them, and it's better to avoid unnecessary code (Binary size matters most
for performance, 99 times out of 99.01).

[maksims (do not use this acc), 2016-07-12 09:18:34]

Patchset #2 (id:20001) has been deleted

[maksims (do not use this acc), 2016-07-12 10:49:25]

https://codereview.chromium.org/2130733003/diff/1/net/http/http_stream_parser.cc
File net/http/http_stream_parser.cc (right):

https://codereview.chromium.org/2130733003/diff/1/net/http/http_stream_parser...
net/http/http_stream_parser.cc:477: // act like the request was successfully
sent.
On 2016/07/11 15:15:35, mmenke wrote:
> I'd suggest adding a new state, DO_SEND_REQUEST_COMPLETE, and have it be the
> only method to call FlushBuffers().
> 
> Also, I'd add DCHECKs in DoLoop, after all the other DoSend cases, to make
sure
> io_state_ is not NONE, to make sure we always go through the new state.  I'd
> also add DCHECKs in HttpStreamParser::Read, to make sure the relevant fields
are
> empty.  Sound good?

Do you like it now?

[mmenke, 2016-07-12 16:13:41]

LGTM!

https://codereview.chromium.org/2130733003/diff/40001/net/http/http_stream_pa...
File net/http/http_stream_parser.cc (right):

https://codereview.chromium.org/2130733003/diff/40001/net/http/http_stream_pa...
net/http/http_stream_parser.cc:1220: void HttpStreamParser::FlushBuffers() {
nit:  You can inline this in HttpStreamParser::DoSendRequestComplete now.

[maksims (do not use this acc), 2016-07-13 07:28:35]

The CQ bit was checked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-07-13 07:28:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2130733003/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-07-13 07:28:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 08:35:32]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[maksims (do not use this acc), 2016-07-13 11:20:15]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 11:20:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-07-13 12:14:15]

The CQ bit was unchecked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-07-13 12:14:21]

The CQ bit was checked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-07-13 12:14:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2130733003/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-13 12:14:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 12:27:35]

Description was changed from

==========
[HttpStreamParser]: Flush buffers as soon as request is sent.

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073
==========

to

==========
[HttpStreamParser]: Flush buffers as soon as request is sent.

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073
==========

[commit-bot: I haz the power, 2016-07-13 12:27:37]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-13 12:27:38]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 12:31:02]

Description was changed from

==========
[HttpStreamParser]: Flush buffers as soon as request is sent.

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073
==========

to

==========
[HttpStreamParser]: Flush buffers as soon as request is sent.

This cl aims on reducing amount of memory used. Once request
is sent, flush buffers to free allocated memory.

BUG=622073

Committed: https://crrev.com/a4fc935d2fde3df3a7bb7d451b4a58f048ee225f
Cr-Commit-Position: refs/heads/master@{#405128}
==========

[commit-bot: I haz the power, 2016-07-13 12:31:03]

Patchset 4 (id:??) landed as
https://crrev.com/a4fc935d2fde3df3a7bb7d451b4a58f048ee225f
Cr-Commit-Position: refs/heads/master@{#405128}