Issue 213073004: Protecting against other possible uses of invalid V8 execution context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213073004: Protecting against other possible uses of invalid V8 execution context. (Closed)

Created:
6 years, 9 months ago by cmumford

Modified:
6 years, 9 months ago

Reviewers:
jsbell

CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Protecting against other possible uses of invalid V8 execution context. Speculative fix for a user reported crash when a worker with an active IndexedDB transaction was terminated. This stack is very similar to the one for 345354. I do not have a reproduction for this bug was unable to verify that it fixes the problem, but checking for a stopped context is still a good idea. BUG=356146, 356171 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170107

Patch Set 1 #

Patch Set 2 : Noted in description that fix is speculative. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/modules/indexeddb/IDBDatabase.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/modules/indexeddb/IDBTransaction.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jsbell

lgtm Any luck with a repro, or just speculative fix? If the latter, you may ...

6 years, 9 months ago (2014-03-26 18:20:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/213073004/20001

6 years, 9 months ago (2014-03-26 21:59:43 UTC) #4

Message was sent while issue was closed.

Change committed as 170107

Expand Messages | Collapse Messages