Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2130703002: Reland of Generate localizable strings in binary1 property list format. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
jif, jif-google
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Generate localizable strings in binary1 property list format. Instead of converting the generated files from the old legacy format to binary1 property list format when creating the application bundle, directly generate them in the correct format. This is a reland of http://crrev.com/2121773002 without any change. The CL was reverted because gyp compilation failed copying the .strings file to the application bundle when they were in binary format. This was fixed by http://crrev.com/2117353002 (rolled as http://crrev/2123963002). BUG=625578 Committed: https://crrev.com/2f2a23432cde68446a2f9ee4f14b533bbcdbdecd Cr-Commit-Position: refs/heads/master@{#404104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M ios/chrome/tools/strings/generate_localizable_strings.mm View 6 chunks +34 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 5 months ago (2016-07-07 08:04:34 UTC) #4
jif-google
lgtm
4 years, 5 months ago (2016-07-07 08:54:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130703002/1
4 years, 5 months ago (2016-07-07 08:54:45 UTC) #8
jif
lgtm
4 years, 5 months ago (2016-07-07 08:54:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 09:16:00 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 09:16:10 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 09:17:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f2a23432cde68446a2f9ee4f14b533bbcdbdecd
Cr-Commit-Position: refs/heads/master@{#404104}

Powered by Google App Engine
This is Rietveld 408576698