Chromium Code Reviews
DescriptionReland of Generate localizable strings in binary1 property list format. (patchset #1 id:1 of https://codereview.chromium.org/2127553002/ )
Reason for revert:
gyp was fixed with https://codereview.chromium.org/2117353002/ and the roll landed with https://codereview.chromium.org/2123963002/.
Relanding.
Original issue's description:
> Revert of Generate localizable strings in binary1 property list format. (patchset #2 id:20001 of https://codereview.chromium.org/2121773002/ )
>
> Reason for revert:
> This breaks the iOS gyp build (gn build works fine).
> https://crbug.com/625819
>
> Original issue's description:
> > Generate localizable strings in binary1 property list format.
> >
> > Instead of converting the generated files from the old legacy format
> > to binary1 property list format when creating the application bundle,
> > directly generate them in the correct format.
> >
> > BUG=625578
> >
> > Committed: https://crrev.com/2e4013a84448cf8e714034e3d9d49d11cdf03227
> > Cr-Commit-Position: refs/heads/master@{#403679}
>
> TBR=stkhapugin@chromium.org,sdefresne@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=625578
>
> Committed: https://crrev.com/46e4613bc67b1fea0fc34893a51b88ad6b276ab3
> Cr-Commit-Position: refs/heads/master@{#403770}
TBR=stkhapugin@chromium.org,jif@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=625578
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|
|||||||||||||||||||