Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2130693002: Reland of Generate localizable strings in binary1 property list format. (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
stkhapugin, jif
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@{0}
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Generate localizable strings in binary1 property list format. (patchset #1 id:1 of https://codereview.chromium.org/2127553002/ ) Reason for revert: gyp was fixed with https://codereview.chromium.org/2117353002/ and the roll landed with https://codereview.chromium.org/2123963002/. Relanding. Original issue's description: > Revert of Generate localizable strings in binary1 property list format. (patchset #2 id:20001 of https://codereview.chromium.org/2121773002/ ) > > Reason for revert: > This breaks the iOS gyp build (gn build works fine). > https://crbug.com/625819 > > Original issue's description: > > Generate localizable strings in binary1 property list format. > > > > Instead of converting the generated files from the old legacy format > > to binary1 property list format when creating the application bundle, > > directly generate them in the correct format. > > > > BUG=625578 > > > > Committed: https://crrev.com/2e4013a84448cf8e714034e3d9d49d11cdf03227 > > Cr-Commit-Position: refs/heads/master@{#403679} > > TBR=stkhapugin@chromium.org,sdefresne@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=625578 > > Committed: https://crrev.com/46e4613bc67b1fea0fc34893a51b88ad6b276ab3 > Cr-Commit-Position: refs/heads/master@{#403770} TBR=stkhapugin@chromium.org,jif@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M ios/chrome/tools/strings/generate_localizable_strings.mm View 6 chunks +34 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sdefresne
Created Reland of Generate localizable strings in binary1 property list format.
4 years, 5 months ago (2016-07-07 07:54:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130693002/1
4 years, 5 months ago (2016-07-07 07:54:57 UTC) #3
sdefresne
4 years, 5 months ago (2016-07-07 07:55:16 UTC) #5
Message was sent while issue was closed.
On 2016/07/07 07:54:57, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Closing this CL, will reland manually.

Powered by Google App Engine
This is Rietveld 408576698