[Experiment] purge-and-suspend

third_party/WebKit/Source/web/WebMemoryCoordinator.cpp

Index: third_party/WebKit/Source/web/WebMemoryCoordinator.cpp
diff --git a/third_party/WebKit/Source/web/WebMemoryCoordinator.cpp b/third_party/WebKit/Source/web/WebMemoryCoordinator.cpp
index 225ee6b90a0ddd70b7ab4bfc33113644e8cef0ed..d26d0ac5818b2d16b058cb4e58f7dd0677fb0dfb 100644
--- a/third_party/WebKit/Source/web/WebMemoryCoordinator.cpp
+++ b/third_party/WebKit/Source/web/WebMemoryCoordinator.cpp
@@ -4,14 +4,25 @@
 
 #include "public/web/WebMemoryCoordinator.h"
 
+#include "bindings/core/v8/V8PerIsolateData.h"
 #include "core/dom/MemoryCoordinator.h"
 #include "core/page/Page.h"
+#include "platform/TraceEvent.h"
+#include "platform/fonts/FontCache.h"
+#include "platform/text/CompressibleString.h"
+
 
 namespace blink {
 
 void WebMemoryCoordinator::onMemoryPressure(WebMemoryPressureLevel pressureLevel)
 {
     MemoryCoordinator::instance().onMemoryPressure(pressureLevel);
+    Page::onMemoryPressure();
+    FontCache::fontCache()->invalidateShapeCache();
+    FontCache::fontCache()->invalidate();
+    V8PerIsolateData::purgeMemory();
+    CompressibleStringImpl::compressAll();
+    WTF::Partitions::decommitFreeableMemory();

[bashi, 2016/07/08 04:16:22]

I think these should be in core::MemoryCoordinator. My understanding is that
web/ shouldn't contain any logic.

[tasak, 2016/07/08 06:47:23]

Since I heard that core and modules will be the same shared library, I think,
it's ok.
(I mean, if we want to keep core and modules different shared libraries, how can
we invoke core logic and module logic?)

However, I think, decommitFreeableMemory should be invoked after invoking all
other purge method.
If we move the code to core, we need to add such comment.
 

[bashi, 2016/07/08 07:09:09]

In this case I think we can add a callback in core/MemoryCoordinator to inverse
core -> modules dependency.
My concern is code organization. These logic should live in core/. web/ should
be as thin as possible. Rationale:
https://codereview.chromium.org/1415663004/diff/60001/third_party/WebKit/Sour...

I may miss something but why can't we call it at the bottom of
MemoryCoordinator::onMemoryPressure()?

[tasak, 2016/07/19 08:22:51]

Done.

 }
 
 } // namespace blink