Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: third_party/WebKit/Source/core/html/forms/OptionListTest.cpp

Issue 2130653002: SELECT element: Introduce light-weight OPTION iterater. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/OptionList.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/forms/OptionListTest.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/OptionListTest.cpp b/third_party/WebKit/Source/core/html/forms/OptionListTest.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..15bdafdd27a39437709fca859fe71daf9d2dd653
--- /dev/null
+++ b/third_party/WebKit/Source/core/html/forms/OptionListTest.cpp
@@ -0,0 +1,89 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/html/forms/OptionList.h"
+
+#include "core/html/HTMLDocument.h"
+#include "core/html/HTMLOptionElement.h"
+#include "core/html/HTMLSelectElement.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+
+namespace {
+
+AtomicString id(const HTMLOptionElement* option)
+{
+ return option->fastGetAttribute(HTMLNames::idAttr);
+}
+
+} // namespace
+
+class OptionListTest : public ::testing::Test {
+protected:
+ void SetUp() override
+ {
+ HTMLDocument* document = HTMLDocument::create();
+ HTMLSelectElement* select = HTMLSelectElement::create(*document);
+ document->appendChild(select);
+ m_select = select;
+ }
+ HTMLSelectElement& select() const { return *m_select; }
+
+private:
+ Persistent<HTMLSelectElement> m_select;
+};
+
+TEST_F(OptionListTest, Empty)
+{
+ OptionList list = select().optionList();
+ EXPECT_EQ(list.end(), list.begin()) << "OptionList should iterate over empty SELECT successfully";
+}
+
+TEST_F(OptionListTest, OptionOnly)
+{
+ select().setInnerHTML("text<input><option id=o1></option><input><option id=o2></option><input>", ASSERT_NO_EXCEPTION);
+ HTMLElement* div = toHTMLElement(select().document().createElement("div", ASSERT_NO_EXCEPTION));
+ div->setInnerHTML("<option id=o3></option>", ASSERT_NO_EXCEPTION);
+ select().appendChild(div);
+ OptionList list = select().optionList();
+ OptionList::Iterator iter = list.begin();
+ EXPECT_EQ("o1", id(*iter));
+ ++iter;
+ EXPECT_EQ("o2", id(*iter));
+ ++iter;
+ // No "o3" because it's in DIV.
+ EXPECT_EQ(list.end(), iter);
+}
+
+TEST_F(OptionListTest, Optgroup)
+{
+ select().setInnerHTML("<optgroup><option id=g11></option><option id=g12></option></optgroup>"
+ "<optgroup><option id=g21></option></optgroup>"
+ "<optgroup></optgroup>"
+ "<option id=o1></option>"
+ "<optgroup><option id=g41></option></optgroup>", ASSERT_NO_EXCEPTION);
+ OptionList list = select().optionList();
+ OptionList::Iterator iter = list.begin();
+ EXPECT_EQ("g11", id(*iter));
+ ++iter;
+ EXPECT_EQ("g12", id(*iter));
+ ++iter;
+ EXPECT_EQ("g21", id(*iter));
+ ++iter;
+ EXPECT_EQ("o1", id(*iter));
+ ++iter;
+ EXPECT_EQ("g41", id(*iter));
+ ++iter;
+ EXPECT_EQ(list.end(), iter);
+
+ toHTMLElement(select().firstChild())->setInnerHTML(
+ "<optgroup><option id=gg11></option></optgroup>"
+ "<option id=g11></option>", ASSERT_NO_EXCEPTION);
+ list = select().optionList();
+ iter = list.begin();
+ EXPECT_EQ("g11", id(*iter)) << "Nested OPTGROUP should be ignored.";
+}
+
+} // naemespace blink
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/OptionList.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698