drawTextRSXform

include/core/SkCanvas.h

Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index ec14829ca85296d12d79d27a04073c6ee587c20e..d70934a3add7d60d894a9dd64ef53335006f91b7 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -989,6 +989,9 @@ public:
     void drawTextOnPath(const void* text, size_t byteLength, const SkPath& path,

[f(malita), 2016/07/07 16:51:05]

Could this be refactored as a drawTextRSXform wrapper at some point?

[reed1, 2016/07/07 18:51:50]

Oddly, no. This guy warps each glyph, bending straight-lines etc. It looks way
pretty, but is very slow (impossible to cache).

What we can do is offer a (non-virtual) helper that looks like
drawTextOnPathRigidRotation, which would call through to drawTextRSXform. This
is basically what I've written in the GM.

                         const SkMatrix* matrix, const SkPaint& paint);
 
+    void drawTextRSXform(const void* text, size_t byteLength, const SkRSXform[],

[f(malita), 2016/07/07 16:51:05]

+ Docs.

[reed1, 2016/07/07 18:51:50]

Done.

+                         const SkPaint& paint);
+
     /** Draw the text blob, offset by (x,y), using the specified paint.
         @param blob     The text blob to be drawn
         @param x        The x-offset of the text being drawn
@@ -1324,6 +1327,8 @@ protected:
     virtual void onDrawTextOnPath(const void* text, size_t byteLength,
                                   const SkPath& path, const SkMatrix* matrix,
                                   const SkPaint& paint);
+    virtual void onDrawTextRSXform(const void* text, size_t byteLength, const SkRSXform[],

[f(malita), 2016/07/07 16:51:04]

+ 100000000 overrides in all SkCanvas subclasses.

[reed1, 2016/07/07 18:51:50]

Eventually. The base impl calls through to a base-impl for device, which is
backward compatible. The only canvases that won't work are ones w/o a device
(e.g. NWay, Picture, some chrome analysis ones). Picture is now updated, and I
will update the others in time... if the client doesn't call this new API, they
won't notice the missing overrides.

+                                   const SkPaint& paint);
 
     virtual void onDrawTextBlob(const SkTextBlob* blob, SkScalar x, SkScalar y,
                                 const SkPaint& paint);