drawTextRSXform

drawTextRSXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004

Committed: https://skia.googlesource.com/skia/+/45561a0b15fe045ba272c328684c3f7ae290785a

[reed1, 2016-07-07 16:24:05]

Description was changed from

==========
drawTextRSXform

BUG=skia:
==========

to

==========
drawTextRSXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004
==========

[reed1, 2016-07-07 16:24:53]

reed@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com, fmalita@chromium.org,
jvanverth@google.com, robertphillips@google.com

[reed1, 2016-07-07 16:24:54]

API check

[reed1, 2016-07-07 16:25:09]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 16:25:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 16:28:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 16:28:46]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[f(malita), 2016-07-07 16:51:05]

lgtm

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h#new...
include/core/SkCanvas.h:989: void drawTextOnPath(const void* text, size_t
byteLength, const SkPath& path,
Could this be refactored as a drawTextRSXform wrapper at some point?

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h#new...
include/core/SkCanvas.h:992: void drawTextRSXform(const void* text, size_t
byteLength, const SkRSXform[],
+ Docs.

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h#new...
include/core/SkCanvas.h:1330: virtual void onDrawTextRSXform(const void* text,
size_t byteLength, const SkRSXform[],
+ 100000000 overrides in all SkCanvas subclasses.

[reed1, 2016-07-07 17:21:30]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 17:21:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 17:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 17:31:08]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[reed1, 2016-07-07 18:38:00]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 18:38:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-07 18:51:50]

ptal

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h#new...
include/core/SkCanvas.h:989: void drawTextOnPath(const void* text, size_t
byteLength, const SkPath& path,
On 2016/07/07 16:51:05, f(malita) wrote:
> Could this be refactored as a drawTextRSXform wrapper at some point?

Oddly, no. This guy warps each glyph, bending straight-lines etc. It looks way
pretty, but is very slow (impossible to cache).

What we can do is offer a (non-virtual) helper that looks like
drawTextOnPathRigidRotation, which would call through to drawTextRSXform. This
is basically what I've written in the GM.

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h#new...
include/core/SkCanvas.h:992: void drawTextRSXform(const void* text, size_t
byteLength, const SkRSXform[],
On 2016/07/07 16:51:05, f(malita) wrote:
> + Docs.

Done.

https://codereview.chromium.org/2130643004/diff/1/include/core/SkCanvas.h#new...
include/core/SkCanvas.h:1330: virtual void onDrawTextRSXform(const void* text,
size_t byteLength, const SkRSXform[],
On 2016/07/07 16:51:04, f(malita) wrote:
> + 100000000 overrides in all SkCanvas subclasses.

Eventually. The base impl calls through to a base-impl for device, which is
backward compatible. The only canvases that won't work are ones w/o a device
(e.g. NWay, Picture, some chrome analysis ones). Picture is now updated, and I
will update the others in time... if the client doesn't call this new API, they
won't notice the missing overrides.

[commit-bot: I haz the power, 2016-07-07 19:02:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 19:02:37]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-07-07 19:24:15]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 19:24:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-07-07 19:42:36]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-07-07 19:42:41]

The CQ bit was checked by reed@google.com

[reed1, 2016-07-07 19:42:41]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/2130643004/#ps80001
(title: "update util canvases")

[commit-bot: I haz the power, 2016-07-07 19:42:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 19:47:20]

Description was changed from

==========
drawTextRSXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004
==========

to

==========
drawTextRSXform

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2130643004

Committed:
https://skia.googlesource.com/skia/+/45561a0b15fe045ba272c328684c3f7ae290785a
==========

[commit-bot: I haz the power, 2016-07-07 19:47:21]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/45561a0b15fe045ba272c328684c3f7ae290785a

[robertphillips, 2016-07-07 20:59:11]

https://codereview.chromium.org/2130643004/diff/80001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2130643004/diff/80001/include/core/SkCanvas.h...
include/core/SkCanvas.h:994: *  If cullRect is not null, it is a conservative
bounds of what will be drawn
stray ')' ?

https://codereview.chromium.org/2130643004/diff/80001/tools/debugger/SkDrawCo...
File tools/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/2130643004/diff/80001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:206: case kDrawTextOnPath_OpType: return
"DrawTextOnPath";
Everyone else starts with a capital 'D' ...

https://codereview.chromium.org/2130643004/diff/80001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:3028: const SkPaint& paint)
Not 'kDrawTextRSXform_OpType' ?

[reed1, 2016-07-07 22:51:45]

follow-up CL: https://codereview.chromium.org/2123923006/#

https://codereview.chromium.org/2130643004/diff/80001/include/core/SkCanvas.h
File include/core/SkCanvas.h (right):

https://codereview.chromium.org/2130643004/diff/80001/include/core/SkCanvas.h...
include/core/SkCanvas.h:994: *  If cullRect is not null, it is a conservative
bounds of what will be drawn
On 2016/07/07 20:59:11, robertphillips wrote:
> stray ')' ?

Done.

https://codereview.chromium.org/2130643004/diff/80001/tools/debugger/SkDrawCo...
File tools/debugger/SkDrawCommand.cpp (right):

https://codereview.chromium.org/2130643004/diff/80001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:206: case kDrawTextOnPath_OpType: return
"DrawTextOnPath";
On 2016/07/07 20:59:11, robertphillips wrote:
> Everyone else starts with a capital 'D' ...

Yes, all of the other ones are wrong.

Done.

https://codereview.chromium.org/2130643004/diff/80001/tools/debugger/SkDrawCo...
tools/debugger/SkDrawCommand.cpp:3028: const SkPaint& paint)
On 2016/07/07 20:59:11, robertphillips wrote:
> Not 'kDrawTextRSXform_OpType' ?

Done.