Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: components/translate/core/browser/translate_ui_delegate.cc

Issue 2130623002: rollback omnibar icon changes based on UX feedback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix patch/merge issue Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate.cc
diff --git a/components/translate/core/browser/translate_ui_delegate.cc b/components/translate/core/browser/translate_ui_delegate.cc
index c3e26406cc780ce6987496817eef9145e5bf3ce6..7caffe1ef1b088fdf578cc99be49aebca85543ef 100644
--- a/components/translate/core/browser/translate_ui_delegate.cc
+++ b/components/translate/core/browser/translate_ui_delegate.cc
@@ -256,12 +256,7 @@ bool TranslateUIDelegate::IsLanguageBlocked() {
void TranslateUIDelegate::SetLanguageBlocked(bool value) {
if (value) {
prefs_->BlockLanguage(GetOriginalLanguageCode());
- // In the new UI, we will keep showing the translate omnibar icon
- // even if the language is blocked so in case the user just wants to
- // translate that page the user can invoke the translate bubble from
- // the omnibar icon.
- if (!base::FeatureList::IsEnabled(kTranslateUI2016Q2) &&
- translate_manager_) {
+ if (translate_manager_) {
translate_manager_->GetLanguageState().SetTranslateEnabled(false);
}
} else {
@@ -283,12 +278,7 @@ void TranslateUIDelegate::SetSiteBlacklist(bool value) {
if (value) {
prefs_->BlacklistSite(host);
- // In the new UI, we will keep showing the translate omnibar icon
- // even if the site is blocked so in case the user just wants to
- // translate that page the user can invoke the translate bubble from
- // the omnibar icon.
- if (!base::FeatureList::IsEnabled(kTranslateUI2016Q2) &&
- translate_manager_) {
+ if (translate_manager_) {
translate_manager_->GetLanguageState().SetTranslateEnabled(false);
}
} else {

Powered by Google App Engine
This is Rietveld 408576698