rollback omnibar icon changes based on UX feedback

remove the omnibar icon changes based on UX feedback

BUG=610376
Committed: https://crrev.com/898979d8cb1874e230621ebf0e4dd0b8208c0894
Cr-Commit-Position: refs/heads/master@{#405235}

[ftang, 2016-07-06 22:48:34]

The CQ bit was checked by ftang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 22:49:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 22:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 22:52:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[ftang, 2016-07-06 23:03:18]

The CQ bit was checked by ftang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 23:04:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-06 23:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 23:09:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ftang, 2016-07-07 20:29:21]

fix patch/merge issue

[ftang, 2016-07-07 20:29:41]

The CQ bit was checked by ftang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 20:30:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ftang, 2016-07-07 22:10:55]

ftang@chromium.org changed reviewers:
+ groby@chromium.org

[commit-bot: I haz the power, 2016-07-07 22:34:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 22:34:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)

[groby-ooo-7-16, 2016-07-11 21:45:18]

On 2016/07/07 22:34:08, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no
build
> URL)

Is this only a rollback of a single CL? In that case, I sugggest using git
revert, i.e.

git revert e9194fafbe858338e049ff946d2f844c20f7c944

But that shouldn't affect 3 CLs, so I'm not sure *which* changes we're rolling
back here?

[ftang, 2016-07-11 22:46:14]

On 2016/07/11 21:45:18, groby wrote:
> On 2016/07/07 22:34:08, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no
> build
> > URL)
> 
> Is this only a rollback of a single CL? In that case, I sugggest using git
> revert, i.e.
> 
> git revert e9194fafbe858338e049ff946d2f844c20f7c944
> 
> But that shouldn't affect 3 CLs, so I'm not sure *which* changes we're rolling
> back here?

No. the original implementation is in two CLs and mixed with other changes. I
probably should
call it "remove" instead of "rollback".

[ftang, 2016-07-13 00:05:55]

Description was changed from

==========
rollback omnibar icon changes based on UX feedback

BUG=610376
==========

to

==========
remove the omnibar icon changes based on UX feedback

BUG=610376
==========

[groby-ooo-7-16, 2016-07-13 00:06:09]

On 2016/07/11 22:46:14, ftang wrote:
> On 2016/07/11 21:45:18, groby wrote:
> > On 2016/07/07 22:34:08, commit-bot: I haz the power wrote:
> > > Dry run: Try jobs failed on following builders:
> > >   mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no
> > build
> > > URL)
> > 
> > Is this only a rollback of a single CL? In that case, I sugggest using git
> > revert, i.e.
> > 
> > git revert e9194fafbe858338e049ff946d2f844c20f7c944
> > 
> > But that shouldn't affect 3 CLs, so I'm not sure *which* changes we're
rolling
> > back here?
> 
> No. the original implementation is in two CLs and mixed with other changes. I
> probably should
> call it "remove" instead of "rollback".

LGTM, please update title and description as you suggested above.

[ftang, 2016-07-13 18:13:55]

The CQ bit was checked by ftang@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:14:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 19:48:06]

Description was changed from

==========
remove the omnibar icon changes based on UX feedback

BUG=610376
==========

to

==========
remove the omnibar icon changes based on UX feedback

BUG=610376
==========

[commit-bot: I haz the power, 2016-07-13 19:48:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 19:49:49]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 19:50:22]

Description was changed from

==========
remove the omnibar icon changes based on UX feedback

BUG=610376
==========

to

==========
remove the omnibar icon changes based on UX feedback

BUG=610376

Committed: https://crrev.com/898979d8cb1874e230621ebf0e4dd0b8208c0894
Cr-Commit-Position: refs/heads/master@{#405235}
==========

[commit-bot: I haz the power, 2016-07-13 19:50:23]

Patchset 2 (id:??) landed as
https://crrev.com/898979d8cb1874e230621ebf0e4dd0b8208c0894
Cr-Commit-Position: refs/heads/master@{#405235}