Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2130613002:
[MD settings] scroll to sections from subpages (Closed)
|
Created:
4 years, 5 months ago by dschuyler Modified:
4 years, 5 months ago Reviewers:
michaelpg CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] scroll to sections from subpages
This CL allows for scrolling to a section from within a sub section.
It also rearranges the behavior logic a bit to make it easier to follow.
BUG=617737
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/fe4a30b0aa4a6ee6b93cc4f6a4c0fd65a5c21d29
Cr-Commit-Position: refs/heads/master@{#406661}
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit change #
Total comments: 2
Messages
Total messages: 19 (9 generated)
Description was changed from ========== [MD settings] scroll to sections from subpages This CL allows for scrolling to a section from within a sub section. It also rearranges the behavior logic a bit to make it easier to follow. BUG=617737 ========== to ========== [MD settings] scroll to sections from subpages This CL allows for scrolling to a section from within a sub section. It also rearranges the behavior logic a bit to make it easier to follow. BUG=617737 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dschuyler@chromium.org changed reviewers: + michaelpg@chromium.org
https://codereview.chromium.org/2130613002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2130613002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/main_page_behavior.js:408: } else { // The new route is a subpage. This could be "else if ...", but I think it is clearer written as an "else".
lgtm https://codereview.chromium.org/2130613002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2130613002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/main_page_behavior.js:408: } else { // The new route is a subpage. On 2016/07/07 17:57:46, dschuyler wrote: > This could be "else if ...", but I think it is clearer > written as an "else". perhaps making the top-level if (newRouteIsSubpage) and swapping the bodies would make it clearerer
Description was changed from ========== [MD settings] scroll to sections from subpages This CL allows for scrolling to a section from within a sub section. It also rearranges the behavior logic a bit to make it easier to follow. BUG=617737 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] scroll to sections from subpages This CL allows for scrolling to a section from within a sub section. It also rearranges the behavior logic a bit to make it easier to follow. BUG=617737 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
For more details, see http://crbug.com/617627.
Swapped if/else blocks
lgtm https://codereview.chromium.org/2130613002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2130613002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_page/main_page_behavior.js:400: if (section) when does this fail? seems like something the router should handle
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2130613002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2130613002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_page/main_page_behavior.js:400: if (section) On 2016/07/20 19:45:05, michaelpg wrote: > when does this fail? seems like something the router should handle This code was simply moved in this CL, so I don't have details about the specific logic. My guess though, would be a unit test issue. That's where I've seen checks like that in the past.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
For more details, see http://crbug.com/617627.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] scroll to sections from subpages This CL allows for scrolling to a section from within a sub section. It also rearranges the behavior logic a bit to make it easier to follow. BUG=617737 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] scroll to sections from subpages This CL allows for scrolling to a section from within a sub section. It also rearranges the behavior logic a bit to make it easier to follow. BUG=617737 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fe4a30b0aa4a6ee6b93cc4f6a4c0fd65a5c21d29 Cr-Commit-Position: refs/heads/master@{#406661} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fe4a30b0aa4a6ee6b93cc4f6a4c0fd65a5c21d29 Cr-Commit-Position: refs/heads/master@{#406661} |
