Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2130603002: ash: Explicitly enumerate repeatable accelerators. (Closed)

Created:
4 years, 5 months ago by Daniel Erat
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Explicitly enumerate repeatable accelerators. Instead of designating specific accelerators as non-repeatable (which is prone to getting outdated), keep track of the few accelerators that should be repeatable. Also make many probably-inadvertently-repeatable accelerators instead be non-repeatable. BUG=626014 TEST=manual Committed: https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8 Cr-Commit-Position: refs/heads/master@{#404161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -49 lines) Patch
M ash/accelerators/accelerator_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 chunk +16 lines, -27 lines 0 comments Download
M ash/accelerators/accelerator_table_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/accelerators/exit_warning_handler.h View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Daniel Erat
4 years, 5 months ago (2016-07-06 22:40:26 UTC) #2
James Cook
LGTM. Thanks for fixing this!
4 years, 5 months ago (2016-07-06 22:49:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130603002/1
4 years, 5 months ago (2016-07-06 23:04:44 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/240837)
4 years, 5 months ago (2016-07-07 00:09:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130603002/1
4 years, 5 months ago (2016-07-07 15:07:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 16:36:09 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 16:36:16 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 16:37:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c061dd11ada8a97335b2ef9b13757cdb780f84e8
Cr-Commit-Position: refs/heads/master@{#404161}

Powered by Google App Engine
This is Rietveld 408576698