Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2130593003: Switch FirefoxImporterTest to ChannelMojo. (Closed)

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 5 months ago
Reviewers:
gab, Ilya Sherman
CC:
chromium-reviews, tfarina, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch FirefoxImporterTest to ChannelMojo. BUG=604282 Committed: https://crrev.com/f2b2c3aea1ae7d78b462329418831517444aab80 Cr-Commit-Position: refs/heads/master@{#404776}

Patch Set 1 #

Patch Set 2 : fix build. #

Patch Set 3 : fix buidl again #

Patch Set 4 : kjfvnkjvcbnkvbj n #

Patch Set 5 : kfjdghkfjgh #

Patch Set 6 : bang head on table #

Total comments: 4

Patch Set 7 : rebase and fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -14 lines) Patch
M chrome/utility/importer/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 1 2 3 4 5 6 5 chunks +40 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130593003/100001
4 years, 5 months ago (2016-07-07 06:46:05 UTC) #2
Anand Mistry (off Chromium)
4 years, 5 months ago (2016-07-07 06:46:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 07:19:28 UTC) #6
gab
Ilya is a better for reviewer for the importers (and myself for the out-of-process import ...
4 years, 5 months ago (2016-07-07 15:13:12 UTC) #8
Ilya Sherman
LGTM -- thanks for working on this! Food for thought: The CL currently adds quite ...
4 years, 5 months ago (2016-07-07 20:14:24 UTC) #9
Anand Mistry (off Chromium)
Re refactoring common code: It turns out, this is the only test which needs this ...
4 years, 5 months ago (2016-07-11 06:59:59 UTC) #10
Ilya Sherman
Okay, thanks for the explanation. Still LGTM.
4 years, 5 months ago (2016-07-11 19:29:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130593003/120001
4 years, 5 months ago (2016-07-12 03:40:05 UTC) #13
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-12 03:46:33 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 03:46:57 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 03:48:45 UTC) #17
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f2b2c3aea1ae7d78b462329418831517444aab80
Cr-Commit-Position: refs/heads/master@{#404776}

Powered by Google App Engine
This is Rietveld 408576698