Issue 2130583003: enable chromium code for GN, bumping warning level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2130583003: enable chromium code for GN, bumping warning level. (Closed)

Created:
4 years, 5 months ago by fbarchard1

Modified:
4 years, 5 months ago

Reviewers:
Robert Sesek

Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master

Target Ref:
refs/heads/master

Project:
libyuv

Visibility:
Public.

enable chromium code for GN, bumping warning level. previously gyp enabled 'chromium_code': 1, for stricter warnings, but GN disabled warnings: configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code" ] This CL enables strict warnings for GN as well as GYP. R=rsesek@chromium.org BUG=libyuv:617 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/5dbfd6d8e61b814ed8112f765f9225142018bb35

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	BUILD.gn	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

fbarchard1

4 years, 5 months ago (2016-07-07 17:47:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5dbfd6d8e61b814ed8112f765f9225142018bb35 (presubmit successful).