Issue 213053003: Fix a few minor issues with promises

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213053003: Fix a few minor issues with promises (Closed)

Created:
6 years, 9 months ago by arv (Not doing code reviews)

Modified:
6 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix a few minor issues with promises We where using the global Promise in a few places where we should ensure that we use the original Promise function instead. LOG=N BUG=None R=rossberg

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	src/promise.js	View		6 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

6 years, 9 months ago (2014-03-26 17:19:14 UTC) #2

On 2014/03/26 16:56:25, arv wrote:
> PTAL

Hi Arv, this is already subsumed by the "ship promises" CL that I had to
roll-back and couldn't reland yet, see

https://codereview.chromium.org/206163004/diff/1/src/promise.js

Expand Messages | Collapse Messages