Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 213053002: Ignore race reports from base::FilePath::StripTrailingSeparatorsInternal() to avoid deadlocks in Th… (Closed)

Created:
6 years, 9 months ago by Alexander Potapenko
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Ignore race reports from base::FilePath::StripTrailingSeparatorsInternal() to avoid deadlocks in ThreadSanitizer. It's crucial to use an ignore instead of a suppression here, because the deadlock happens before the suppressions are being checked. TSan builders have to be clobbered in order for this change to take effect. BUG=356676 TBR=thakis@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259595

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/valgrind/tsan_v2/ignores.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexander Potapenko
TBR
6 years, 9 months ago (2014-03-26 15:38:12 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-26 15:38:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/213053002/1
6 years, 9 months ago (2014-03-26 15:39:00 UTC) #3
Nico
lgtm, but why does this require a clobber?
6 years, 9 months ago (2014-03-26 15:43:44 UTC) #4
Alexander Potapenko
On 2014/03/26 15:43:44, Nico wrote: > lgtm, but why does this require a clobber? Because ...
6 years, 9 months ago (2014-03-26 15:49:28 UTC) #5
Alexander Potapenko
On 2014/03/26 15:49:28, Alexander Potapenko wrote: > On 2014/03/26 15:43:44, Nico wrote: > > lgtm, ...
6 years, 9 months ago (2014-03-26 15:49:56 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 16:02:29 UTC) #7
Message was sent while issue was closed.
Change committed as 259595

Powered by Google App Engine
This is Rietveld 408576698