Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2130523002: Fix aspect ratio for rounded background image size (Closed)

Created:
4 years, 5 months ago by Stephen Chennney
Modified:
4 years, 5 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix aspect ratio for rounded background image size The previous calculation to maintain aspect size when one background image dimension is round and the other is auto was using the new tile size for the rounded dimension for the aspect ratio calculation, which is wrong. This change switches to using the original aspect ratio. New tests for both horizontal and vertical cases. R=fmalita@chromium.org BUG=612278 Committed: https://crrev.com/60855ad5ed67add982bf86c34cb14b44e7b85b75 Cr-Commit-Position: refs/heads/master@{#404154}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Remove new tests; we already have coverage #

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130523002/1
4 years, 5 months ago (2016-07-06 19:20:50 UTC) #2
Stephen Chennney
Locally some tests have new results: svg/as-background-image/background-repeat.html was wrong is now correct. ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio.htm was wrong ...
4 years, 5 months ago (2016-07-06 20:07:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130523002/40001
4 years, 5 months ago (2016-07-06 20:25:23 UTC) #5
f(malita)
lgtm
4 years, 5 months ago (2016-07-06 20:46:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130523002/40001
4 years, 5 months ago (2016-07-06 20:55:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99375)
4 years, 5 months ago (2016-07-06 23:49:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130523002/40001
4 years, 5 months ago (2016-07-07 13:35:36 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-07 14:10:31 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 14:10:34 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 14:12:08 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60855ad5ed67add982bf86c34cb14b44e7b85b75
Cr-Commit-Position: refs/heads/master@{#404154}

Powered by Google App Engine
This is Rietveld 408576698