Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2130513002: Minor typos in v8.h code documentation. (Closed)

Created:
4 years, 5 months ago by danbev
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
git@github.com:danbev/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor typos in v8.h code documentation. When reading through the source code (v8.h) I found some minor typos which I wanted to report. BUG= Committed: https://crrev.com/d52b403f51ee52507ad0ef83645aef551cce8962 Cr-Commit-Position: refs/heads/master@{#37835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M include/v8.h View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
danbev
4 years, 5 months ago (2016-07-06 18:50:32 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-07 08:07:36 UTC) #3
danbev
On 2016/07/07 08:07:36, jochen wrote: > lgtm Would it be alright for me to check ...
4 years, 5 months ago (2016-07-14 19:04:59 UTC) #4
jochen (gone - plz use gerrit)
right, if nobody raised an objection that isn't yet addressed, go ahead and click the ...
4 years, 5 months ago (2016-07-18 11:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130513002/1
4 years, 5 months ago (2016-07-18 12:07:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 12:36:58 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 12:37:01 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 12:39:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d52b403f51ee52507ad0ef83645aef551cce8962
Cr-Commit-Position: refs/heads/master@{#37835}

Powered by Google App Engine
This is Rietveld 408576698