Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 21305005: FileAPI: Move OpenFileSystem into SandboxContext (Closed)

Created:
7 years, 4 months ago by nhiroki
Modified:
7 years, 4 months ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

FileAPI: Move OpenFileSystem into SandboxContext This moves SandboxFileSystemBackend::OpenFileSystem to SandboxContext so that the backend can share the function with SyncFileSystemBackend which will be introduced in the following CL. BUG=242422 TEST=content_unittests R=kinuko@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214991

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -113 lines) Patch
M webkit/browser/fileapi/sandbox_context.h View 5 chunks +18 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/sandbox_context.cc View 7 chunks +112 lines, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.cc View 1 3 chunks +5 lines, -105 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nhiroki
Can you review this? Thanks!
7 years, 4 months ago (2013-07-31 08:10:43 UTC) #1
kinuko
lgtm (Maybe SandboxContext needs a better name)
7 years, 4 months ago (2013-07-31 09:24:33 UTC) #2
tzik
lgtm
7 years, 4 months ago (2013-08-01 03:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/21305005/19001
7 years, 4 months ago (2013-08-01 06:38:57 UTC) #4
nhiroki
7 years, 4 months ago (2013-08-01 08:17:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r214991 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698