Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 2130493002: Implement THROTTLED priority semantics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NetworkStreamThrottler
Patch Set: Added tests and cleaned up code. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index de2c8de131e8557906a25463b8124a34dac4daaa..38f5d274559a67a97bc85197c020d8dd04e92d1e 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -141,7 +141,7 @@ class TestNetworkStreamThrottler : public NetworkThrottleManager {
void UnthrottleAllRequests() {
std::set<TestThrottle*> outstanding_throttles_copy(outstanding_throttles_);
for (auto& throttle : outstanding_throttles_copy) {
- if (throttle->IsThrottled())
+ if (throttle->IsBlocked())
throttle->Unthrottle();
}
}
@@ -168,7 +168,11 @@ class TestNetworkStreamThrottler : public NetworkThrottleManager {
~TestThrottle() override { throttler_->OnThrottleDestroyed(this); }
// Throttle
- bool IsThrottled() const override { return throttled_; }
+ bool IsBlocked() const override { return throttled_; }
+ RequestPriority Priority() const override {
+ NOTREACHED();
+ return IDLE;
+ }
void SetPriority(RequestPriority priority) override {
throttler_->SetPriorityCalled(priority);
}
@@ -182,7 +186,7 @@ class TestNetworkStreamThrottler : public NetworkThrottleManager {
EXPECT_TRUE(throttled_);
throttled_ = false;
- delegate_->OnThrottleStateChanged();
+ delegate_->OnThrottleStateChanged(this);
}
bool throttled_;

Powered by Google App Engine
This is Rietveld 408576698