Implement THROTTLED priority semantics.

content/browser/android/url_request_content_job_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/url_request_content_job.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 29 matching lines @@
 
   net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
       const std::string& scheme,
       net::URLRequest* request,
       net::NetworkDelegate* network_delegate) const override {
     URLRequestContentJob* job =
         new URLRequestContentJob(
             request,
             network_delegate,
             path_,
-            const_cast<base::MessageLoop*>(&message_loop_)->task_runner());
+            base::MessageLoop::current()->task_runner());

[Ryan Sleevi, 2016/11/07 16:21:38]

Shouldn't this be
https://cs.chromium.org/chromium/src/base/threading/thread_task_runner_handle...

[Randy Smith (Not in Mondays), 2016/11/07 16:58:09]

Given the amount of pain switching over to TTRH cost me when I did it in the
core of this CL (see long list of things Matt has to review), I am totally not
going to do it in someone else's test without an OWNER's request.  At least not
unless you jump up and down and yell about it.  

[Ryan Sleevi, 2016/11/07 17:09:43]

Well, this is directly being touched by you because of line 81 - so I do believe
you're on the hook for this change - either in this CL or immediately following
it :)

     observer_->OnJobCreated();
     return job;
   }
 
   net::URLRequestJob* MaybeInterceptRedirect(
       net::URLRequest* request,
       net::NetworkDelegate* network_delegate,
       const GURL& location) const override {
     return nullptr;
   }
@@ skipping 10 matching lines @@
 
   bool IsHandledURL(const GURL& url) const override {
     return IsHandledProtocol(url.scheme());
   }
 
   bool IsSafeRedirectTarget(const GURL& location) const override {
     return false;
   }
 
  private:
-  base::MessageLoop message_loop_;
   base::FilePath path_;
   JobObserver* observer_;
 };
 
 class JobObserverImpl : public CallbacksJobFactory::JobObserver {
  public:
   JobObserverImpl() : num_jobs_created_(0) {}
   ~JobObserverImpl() override {}
 
   void OnJobCreated() override { ++num_jobs_created_; }
@@ skipping 22 matching lines @@
   URLRequestContentJobTest();
 
  protected:
   // This inserts an image file into the android MediaStore and retrieves the
   // content URI. Then creates and runs a URLRequestContentJob to get the
   // contents out of it. If a Range is provided, this function will add the
   // appropriate Range http header to the request and verify the bytes
   // retrieved.
   void RunRequest(const Range* range);
 
+  base::MessageLoop message_loop_;
   JobObserverImpl observer_;
   net::TestURLRequestContext context_;
   net::TestDelegate delegate_;
 };
 
 URLRequestContentJobTest::URLRequestContentJobTest() {}
 
 void URLRequestContentJobTest::RunRequest(const Range* range) {
   base::FilePath test_dir;
   PathService::Get(base::DIR_SOURCE_ROOT, &test_dir);
@@ skipping 58 matching lines @@
 }
 
 TEST_F(URLRequestContentJobTest, ContentURIWithZeroRange) {
   Range range(0, 0);
   RunRequest(&range);
 }
 
 }  // namespace
 
 }  // namespace content