Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2130463002:
Mojo C++ bindings: allow StructTraits to return handle or interface types as value. (Closed)
|
Created:
4 years, 5 months ago by yzshen1 Modified:
4 years, 5 months ago Reviewers:
Peng CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMojo C++ bindings: allow StructTraits to return handle or interface types as value.
BUG=None
Committed: https://crrev.com/2e4dc1d8ca9272837a42daba2626bcd026fd03d8
Cr-Commit-Position: refs/heads/master@{#404035}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 20 (7 generated)
yzshen@chromium.org changed reviewers: + penghuang@chromium.org
Hi, Peng. Would you please take a look? Thanks!
https://codereview.chromium.org/2130463002/diff/1/mojo/public/cpp/bindings/te... File mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h (right): https://codereview.chromium.org/2130463002/diff/1/mojo/public/cpp/bindings/te... mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h:105: return std::move(value.get_mutable_handle()); Yes. This is what I need. https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... File mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl (right): https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl:80: {%- if kind|is_array_kind or kind|is_map_kind %} This code is totally unreadable to me. Maybe ask other to take a look.
https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... File mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl (right): https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl:80: {%- if kind|is_array_kind or kind|is_map_kind %} On 2016/07/06 18:05:26, Peng wrote: > This code is totally unreadable to me. Maybe ask other to take a look. I am the author of most of the code in this folder. :) If you think it does what you want, would you please LG this CL.
On 2016/07/06 18:07:25, yzshen1 wrote: > https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... > File mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl > (right): > > https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... > mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl:80: {%- > if kind|is_array_kind or kind|is_map_kind %} > On 2016/07/06 18:05:26, Peng wrote: > > This code is totally unreadable to me. Maybe ask other to take a look. > > I am the author of most of the code in this folder. :) > If you think it does what you want, would you please LG this CL. LGTM. Thanks.
On 2016/07/06 18:07:25, yzshen1 wrote: > https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... > File mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl > (right): > > https://codereview.chromium.org/2130463002/diff/1/mojo/public/tools/bindings/... > mojo/public/tools/bindings/generators/cpp_templates/struct_macros.tmpl:80: {%- > if kind|is_array_kind or kind|is_map_kind %} > On 2016/07/06 18:05:26, Peng wrote: > > This code is totally unreadable to me. Maybe ask other to take a look. > > I am the author of most of the code in this folder. :) > If you think it does what you want, would you please LG this CL. LGTM. Thanks.
The CQ bit was checked by yzshen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yzshen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yzshen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Mojo C++ bindings: allow StructTraits to return handle or interface types as value. BUG=None ========== to ========== Mojo C++ bindings: allow StructTraits to return handle or interface types as value. BUG=None Committed: https://crrev.com/2e4dc1d8ca9272837a42daba2626bcd026fd03d8 Cr-Commit-Position: refs/heads/master@{#404035} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2e4dc1d8ca9272837a42daba2626bcd026fd03d8 Cr-Commit-Position: refs/heads/master@{#404035} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
