Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2130453006: Show empty bell icon in notification button initially (Closed)

Created:
4 years, 5 months ago by yoshiki
Modified:
4 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show empty bell icon in notification button initially We have to show the empty bell icon in the initial state, since there is no notification in the message center at first. BUG=617870 BUG=b:28823597 Committed: https://crrev.com/b7f49840eb4c80f98c30e599fb39ae1a41a6eefc Cr-Commit-Position: refs/heads/master@{#404960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
yoshiki
Steven, PTAL
4 years, 5 months ago (2016-07-12 06:32:17 UTC) #4
stevenjb
lgtm
4 years, 5 months ago (2016-07-12 18:14:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130453006/1
4 years, 5 months ago (2016-07-13 01:03:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 03:27:54 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:30:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7f49840eb4c80f98c30e599fb39ae1a41a6eefc
Cr-Commit-Position: refs/heads/master@{#404960}

Powered by Google App Engine
This is Rietveld 408576698