Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: sync/engine/conflict_util.cc

Issue 2130453004: [Sync] Move //sync to //components/sync. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/engine/conflict_util.h ('k') | sync/engine/directory_commit_contribution.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/conflict_util.cc
diff --git a/sync/engine/conflict_util.cc b/sync/engine/conflict_util.cc
deleted file mode 100644
index dd4457b6bd5b2cda86158271664f8ba23c9edf09..0000000000000000000000000000000000000000
--- a/sync/engine/conflict_util.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "sync/engine/conflict_util.h"
-
-#include "sync/syncable/mutable_entry.h"
-
-namespace syncer {
-
-using syncable::MutableEntry;
-
-namespace conflict_util {
-
-// Allow the server's changes to take precedence.
-// This will take effect during the next ApplyUpdates step.
-void IgnoreLocalChanges(MutableEntry* entry) {
- DCHECK(entry->GetIsUnsynced());
- DCHECK(entry->GetIsUnappliedUpdate());
- entry->PutIsUnsynced(false);
-}
-
-// Overwrite the server with our own value.
-// We will commit our local data, overwriting the server, at the next
-// opportunity.
-void OverwriteServerChanges(MutableEntry* entry) {
- DCHECK(entry->GetIsUnsynced());
- DCHECK(entry->GetIsUnappliedUpdate());
- entry->PutBaseVersion(entry->GetServerVersion());
- entry->PutIsUnappliedUpdate(false);
-}
-
-// Having determined that everything matches, we ignore the non-conflict.
-void IgnoreConflict(MutableEntry* entry) {
- // If we didn't also unset IS_UNAPPLIED_UPDATE, then we would lose unsynced
- // positional data from adjacent entries when the server update gets applied
- // and the item is re-inserted into the PREV_ID/NEXT_ID linked list. This is
- // primarily an issue because we commit after applying updates, and is most
- // commonly seen when positional changes are made while a passphrase is
- // required (and hence there will be many encryption conflicts).
- DCHECK(entry->GetIsUnsynced());
- DCHECK(entry->GetIsUnappliedUpdate());
- entry->PutBaseVersion(entry->GetServerVersion());
- entry->PutIsUnappliedUpdate(false);
- entry->PutIsUnsynced(false);
-}
-
-} // namespace conflict_util
-} // namespace syncer
« no previous file with comments | « sync/engine/conflict_util.h ('k') | sync/engine/directory_commit_contribution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698