Remove calls to MessageLoop::current() in tools.

Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
Committed: https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea
Cr-Commit-Position: refs/heads/master@{#406006}

[fdoray, 2016-07-06 17:34:18]

Description was changed from

==========
Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
==========

to

==========
Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
==========

[fdoray, 2016-07-06 17:34:19]

fdoray@chromium.org changed reviewers:
+ thakis@chromium.org

[fdoray, 2016-07-06 19:57:13]

Can you review this CL? Thanks.

[Nico, 2016-07-06 20:22:48]

since these are all in tools/gn, you probably want a tools/gn/owner

[fdoray, 2016-07-06 20:24:18]

fdoray@chromium.org changed reviewers:
+ brettw@chromium.org
- thakis@chromium.org

[fdoray, 2016-07-06 20:24:18]

brettw@: Can you review this CL? Thanks.

[brettw, 2016-07-11 20:47:25]

lgtm

https://codereview.chromium.org/2130443002/diff/20001/tools/gn/loader.cc
File tools/gn/loader.cc (right):

https://codereview.chromium.org/2130443002/diff/20001/tools/gn/loader.cc#newc...
tools/gn/loader.cc:103: if (base::ThreadTaskRunnerHandle::IsSet())
Can you add a comment here that there may be no active task runner set at this
point, in which case we expect the calling code to call set_task_runner(). It
initially looked weird that you handled the unset case.

[fdoray, 2016-07-18 15:28:40]

https://codereview.chromium.org/2130443002/diff/20001/tools/gn/loader.cc
File tools/gn/loader.cc (right):

https://codereview.chromium.org/2130443002/diff/20001/tools/gn/loader.cc#newc...
tools/gn/loader.cc:103: if (base::ThreadTaskRunnerHandle::IsSet())
On 2016/07/11 20:47:25, brettw (ping after 24h) wrote:
> Can you add a comment here that there may be no active task runner set at this
> point, in which case we expect the calling code to call set_task_runner(). It
> initially looked weird that you handled the unset case.

Done.

[fdoray, 2016-07-18 15:28:43]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-07-18 15:28:44]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2130443002/#ps40001
(title: "CR brettw (add comment)")

[commit-bot: I haz the power, 2016-07-18 15:29:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 16:05:33]

Description was changed from

==========
Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
==========

to

==========
Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
==========

[commit-bot: I haz the power, 2016-07-18 16:05:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-18 16:05:43]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 16:07:05]

Description was changed from

==========
Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447
==========

to

==========
Remove calls to MessageLoop::current() in tools.

Why?
The fact that there's a MessageLoop on the thread is an
unnecessary implementation detail. When browser threads
are migrated to base/task_scheduler, tasks will no longer
have access to a MessageLoop.

These changes were generated manually.

BUG=616447

Committed: https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea
Cr-Commit-Position: refs/heads/master@{#406006}
==========

[commit-bot: I haz the power, 2016-07-18 16:07:06]

Patchset 3 (id:??) landed as
https://crrev.com/f0544fc6ed9a3477926b3640fae9706836f211ea
Cr-Commit-Position: refs/heads/master@{#406006}