Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2130393002: Improve PolicyUrlFilteringTest to correctly wait for onReceivedError() (Closed)

Created:
4 years, 5 months ago by gsennton
Modified:
4 years, 5 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, dgn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve PolicyUrlFilteringTest to correctly wait for onReceivedError() The test PolicyUrlFilteringTest#testBlacklistedUrl is sometimes failing because it is expecting an onReceivedError callback. A potential reason for this failure could be that the test is not correctly waiting for the callback to be called. BUG=623586 Committed: https://crrev.com/28a8884d13b06372967bcffe3f257455dfc37fed Cr-Commit-Position: refs/heads/master@{#404440}

Patch Set 1 #

Patch Set 2 : Learn how to use waitForCallback correctly >.< #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/PolicyUrlFilteringTest.java View 1 4 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
gsennton
4 years, 5 months ago (2016-07-08 15:17:26 UTC) #2
Torne
lgtm
4 years, 5 months ago (2016-07-08 15:30:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130393002/1
4 years, 5 months ago (2016-07-08 15:44:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/100627)
4 years, 5 months ago (2016-07-08 16:34:38 UTC) #7
gsennton
Woopsie (I didn't run the tests locally before committing because I ran into an issue ...
4 years, 5 months ago (2016-07-08 16:55:22 UTC) #9
sgurun-gerrit only
On 2016/07/08 16:55:22, gsennton wrote: > Woopsie (I didn't run the tests locally before committing ...
4 years, 5 months ago (2016-07-08 17:00:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130393002/20001
4 years, 5 months ago (2016-07-08 17:02:32 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 18:13:51 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 18:13:52 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 18:15:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28a8884d13b06372967bcffe3f257455dfc37fed
Cr-Commit-Position: refs/heads/master@{#404440}

Powered by Google App Engine
This is Rietveld 408576698