Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2130383003: Convert video-poster* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-poster* tests to testharness.js Cleaning up video-poster* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/c1362436b588e77b1a91f2ba3fdd28ceaeea7d28 Cr-Commit-Position: refs/heads/master@{#405125}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -269 lines) Patch
M third_party/WebKit/LayoutTests/media/video-poster.html View 1 1 chunk +73 lines, -140 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-poster-delayed.html View 1 chunk +27 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-poster-delayed-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-poster-expected.txt View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-08 18:39:36 UTC) #4
fs
lgtm https://codereview.chromium.org/2130383003/diff/20001/third_party/WebKit/LayoutTests/media/video-poster.html File third_party/WebKit/LayoutTests/media/video-poster.html (right): https://codereview.chromium.org/2130383003/diff/20001/third_party/WebKit/LayoutTests/media/video-poster.html#newcode10 third_party/WebKit/LayoutTests/media/video-poster.html:10: url: null, reflectedUrl: "", width: 320, height: 240, ...
4 years, 5 months ago (2016-07-12 17:52:00 UTC) #5
Srirama
https://codereview.chromium.org/2130383003/diff/20001/third_party/WebKit/LayoutTests/media/video-poster.html File third_party/WebKit/LayoutTests/media/video-poster.html (right): https://codereview.chromium.org/2130383003/diff/20001/third_party/WebKit/LayoutTests/media/video-poster.html#newcode10 third_party/WebKit/LayoutTests/media/video-poster.html:10: url: null, reflectedUrl: "", width: 320, height: 240, setSize: ...
4 years, 5 months ago (2016-07-13 10:47:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130383003/40001
4 years, 5 months ago (2016-07-13 10:47:28 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-13 11:58:41 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 11:58:45 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 12:00:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c1362436b588e77b1a91f2ba3fdd28ceaeea7d28
Cr-Commit-Position: refs/heads/master@{#405125}

Powered by Google App Engine
This is Rietveld 408576698