Issue 213038: Fix an off by 1 error in the Linux Breakpad guid....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213038: Fix an off by 1 error in the Linux Breakpad guid.... (Closed)

Created:
11 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix an off by 1 error in the Linux Breakpad guid. BUG=22067 TEST=No more random strings in crash client GUIDs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26991

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/app/breakpad_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/renderer_host/render_crash_handler_host_linux.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

I think the array size was correct at some point, and I forgot to update ...

11 years, 3 months ago (2009-09-19 02:09:55 UTC) #1

agl

11 years, 3 months ago (2009-09-23 20:50:04 UTC) #3

LGTM.

(Sorry, you got lost in the post-vacation email overload.)