Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2130363002: [NTP Snippets] Remove deprecated prefs (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Remove deprecated prefs BUG=617585 Committed: https://crrev.com/3a1752d314f7596c834f93fb20d78e893ce8b81a Cr-Commit-Position: refs/heads/master@{#404616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M components/ntp_snippets/pref_names.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/ntp_snippets/pref_names.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Marc Treib
PTAL!
4 years, 5 months ago (2016-07-08 13:10:40 UTC) #2
dgn
I was about to do it ^^ lgtm
4 years, 5 months ago (2016-07-08 23:52:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130363002/1
4 years, 5 months ago (2016-07-11 07:56:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 08:33:55 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 08:34:01 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:35:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a1752d314f7596c834f93fb20d78e893ce8b81a
Cr-Commit-Position: refs/heads/master@{#404616}

Powered by Google App Engine
This is Rietveld 408576698