Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2130353002: Prevents the shortcuts DB from going out of scope before unittests run. (Closed)

Created:
4 years, 5 months ago by rohitrao (ping after 24h)
Modified:
4 years, 5 months ago
Reviewers:
Mark P, justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevents the shortcuts DB from going out of scope before unittests run. The ScopedTempDir is now an ivar of the test fixture, so that it survives past the end of SetUp(). BUG=None Committed: https://crrev.com/edf71b08c2320e1dcb8bd35232c823f29b67e535 Cr-Commit-Position: refs/heads/master@{#404427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/omnibox/browser/shortcuts_database_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rohitrao (ping after 24h)
4 years, 5 months ago (2016-07-08 12:24:20 UTC) #3
justincohen
lgtm
4 years, 5 months ago (2016-07-08 12:25:10 UTC) #5
Mark P
lgtm
4 years, 5 months ago (2016-07-08 17:18:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130353002/1
4 years, 5 months ago (2016-07-08 17:22:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 17:28:43 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 17:28:59 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 17:31:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edf71b08c2320e1dcb8bd35232c823f29b67e535
Cr-Commit-Position: refs/heads/master@{#404427}

Powered by Google App Engine
This is Rietveld 408576698