Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2130303002: Revert of [gn] Switch gcc bots to gn (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@ng58
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ ) Reason for revert: There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068 Original issue's description: > [gn] Switch gcc bots to gn > > BUG=chromium:474921 > > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 > Cr-Commit-Position: refs/heads/master@{#37580} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/980d0d6e227f8de3cc0b71a0d3f492908adcf138 Cr-Commit-Position: refs/heads/master@{#37603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M infra/mb/mb_config.pyl View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
Created Revert of [gn] Switch gcc bots to gn
4 years, 5 months ago (2016-07-08 09:34:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130303002/1
4 years, 5 months ago (2016-07-08 09:34:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 09:34:37 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/980d0d6e227f8de3cc0b71a0d3f492908adcf138 Cr-Commit-Position: refs/heads/master@{#37603}
4 years, 5 months ago (2016-07-08 09:36:47 UTC) #7
Michael Achenbach
This revert was probably unnecessary, as the bot still fails. But I keep it until ...
4 years, 5 months ago (2016-07-08 10:02:13 UTC) #8
Michael Achenbach
4 years, 5 months ago (2016-07-11 07:24:38 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2132333002/ by machenbach@chromium.org.

The reason for reverting is: Relanding as the goma problem is due to an upgrade
of the binutils version we use..

Powered by Google App Engine
This is Rietveld 408576698