Change OOMs to raise custom exception rather than breakpoint on Windows.

Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/8ca194a234f2ec714a46da50b2e10f2b651b9aba
Cr-Commit-Position: refs/heads/master@{#406458}

[Will Harris, 2016-07-08 23:01:43]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

BUG=614440
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Will Harris, 2016-07-11 17:53:28]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Will Harris, 2016-07-11 17:53:29]

wfh@chromium.org changed reviewers:
+ jochen@chromium.org

[Will Harris, 2016-07-11 17:54:40]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This is the blink/chromium CL. There are other CLs for v8 and skia required.

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Will Harris, 2016-07-11 17:55:01]

hi jochen - I wonder what you think about this CL/bug?

[haraken, 2016-07-11 23:06:35]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-07-11 23:06:36]

https://codereview.chromium.org/2130293003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2130293003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:98: /*

Should this code be commented out?

[Will Harris, 2016-07-11 23:11:20]

https://codereview.chromium.org/2130293003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2130293003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:98: /*
On 2016/07/11 23:06:35, haraken wrote:
> 
> Should this code be commented out?

yeah I can't call this until the API exists in V8 and that is in another CL that
will have to be committed before this one (I haven't uploaded it yet).

[Will Harris, 2016-07-11 23:33:04]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This is the blink/chromium CL. There are other CLs for v8 and skia required.

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This is the blink/chromium CL. There are other CLs for v8 and skia required.

V8 - https://codereview.chromium.org/2139873002

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Will Harris, 2016-07-11 23:33:23]

On 2016/07/11 23:11:20, Will Harris wrote:
>
https://codereview.chromium.org/2130293003/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):
> 
>
https://codereview.chromium.org/2130293003/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:98: /*
> On 2016/07/11 23:06:35, haraken wrote:
> > 
> > Should this code be commented out?
> 
> yeah I can't call this until the API exists in V8 and that is in another CL
that
> will have to be committed before this one (I haven't uploaded it yet).

The V8 CL is https://codereview.chromium.org/2139873002

[Will Harris, 2016-07-15 00:42:10]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This is the blink/chromium CL. There are other CLs for v8 and skia required.

V8 - https://codereview.chromium.org/2139873002

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Will Harris, 2016-07-15 15:33:17]

wfh@chromium.org changed reviewers:
+ mtklein@chromium.org

[Will Harris, 2016-07-15 15:38:30]

wfh@chromium.org changed reviewers:
+ asvitkine@chromium.org, thakis@chromium.org

[Will Harris, 2016-07-15 15:39:48]

wfh@chromium.org changed reviewers:
- haraken@chromium.org, jochen@chromium.org

[Will Harris, 2016-07-15 15:40:05]

wfh@chromium.org changed reviewers:
+ jochen@chromium.org

[Will Harris, 2016-07-15 15:41:16]

PTAL

skia/ext/SkMemory_new_handler.cpp -> mtklein
third_party/WebKit/* -> jochen
content/* -> jochen
tools/metrics/histograms/histograms.xml -> asvitkine
base/process/* -> thakis

thakis/jochen also look over the general approach I'm taking here if possible,
thanks.

[Alexei Svitkine (slow), 2016-07-15 15:44:58]

histograms.xml lgtm

[haraken, 2016-07-15 16:01:20]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-07-15 16:01:23]

WebKit LGTM

https://codereview.chromium.org/2130293003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2130293003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:102: printf("V8 %s
OOM: (%s).  Current memory usage: %d MB\n", isJsHeap ? "javascript" : "process",
location, memoryUsageMB);

We should avoid using printf. Use WTF_LOG instead.

[Will Harris, 2016-07-15 16:11:42]

https://codereview.chromium.org/2130293003/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2130293003/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:102: printf("V8 %s
OOM: (%s).  Current memory usage: %d MB\n", isJsHeap ? "javascript" : "process",
location, memoryUsageMB);
On 2016/07/15 16:01:23, haraken wrote:
> 
> We should avoid using printf. Use WTF_LOG instead.

Done. WTF_LOG is deprecated so I used VLOG.

[mtklein_C, 2016-07-15 16:18:05]

lgtm

[jochen (gone - plz use gerrit), 2016-07-18 11:44:34]

https://codereview.chromium.org/2130293003/diff/120001/chrome/common/url_cons...
File chrome/common/url_constants.h (right):

https://codereview.chromium.org/2130293003/diff/120001/chrome/common/url_cons...
chrome/common/url_constants.h:197: extern const char
kChromeUIMemoryExhaustHost[];
shouldn't that be defined alongside the URL in content?

[Will Harris, 2016-07-18 18:33:56]

PTAL and I have a question about DVLOG or VLOG.

https://codereview.chromium.org/2130293003/diff/120001/chrome/common/url_cons...
File chrome/common/url_constants.h (right):

https://codereview.chromium.org/2130293003/diff/120001/chrome/common/url_cons...
chrome/common/url_constants.h:197: extern const char
kChromeUIMemoryExhaustHost[];
On 2016/07/18 11:44:34, jochen wrote:
> shouldn't that be defined alongside the URL in content?

Done.

https://codereview.chromium.org/2130293003/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2130293003/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:102: DVLOG(1) <<
"V8 " << (isJsHeap ? "javascript" : "process") << " OOM: (" << location << "). 
Current memory usage: " << memoryUsageMB << " MB";
I made this a DVLOG instead of a VLOG so it won't be in release builds. It seems
DVLOG is used far more often in blink than VLOG... Do you feel that this should
be a VLOG or a DVLOG?

[haraken, 2016-07-18 22:45:38]

On 2016/07/18 18:33:56, Will Harris wrote:
> PTAL and I have a question about DVLOG or VLOG.
> 
>
https://codereview.chromium.org/2130293003/diff/120001/chrome/common/url_cons...
> File chrome/common/url_constants.h (right):
> 
>
https://codereview.chromium.org/2130293003/diff/120001/chrome/common/url_cons...
> chrome/common/url_constants.h:197: extern const char
> kChromeUIMemoryExhaustHost[];
> On 2016/07/18 11:44:34, jochen wrote:
> > shouldn't that be defined alongside the URL in content?
> 
> Done.
> 
>
https://codereview.chromium.org/2130293003/diff/140001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):
> 
>
https://codereview.chromium.org/2130293003/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:102: DVLOG(1) <<
> "V8 " << (isJsHeap ? "javascript" : "process") << " OOM: (" << location << ").

> Current memory usage: " << memoryUsageMB << " MB";
> I made this a DVLOG instead of a VLOG so it won't be in release builds. It
seems
> DVLOG is used far more often in blink than VLOG... Do you feel that this
should
> be a VLOG or a DVLOG?

I don't have a strong opinion but would prefer DVLOG (since VLOG messes up
console output of release builds).

[jochen (gone - plz use gerrit), 2016-07-19 12:22:51]

lgtm

[Will Harris, 2016-07-19 15:59:13]

wfh@chromium.org changed reviewers:
+ dcheng@chromium.org
- thakis@chromium.org

[Will Harris, 2016-07-19 15:59:56]

thakis appears to be OOO so base/ -> dcheng. Thanks!

[Will Harris, 2016-07-19 16:53:44]

On 2016/07/19 15:59:56, Will Harris wrote:
> thakis appears to be OOO so base/ -> dcheng. Thanks!

[Will Harris, 2016-07-19 16:56:20]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

BUG=614440
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mark Mentovai, 2016-07-19 20:32:07]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2016-07-19 20:32:08]

LGTM otherwise in base.

https://codereview.chromium.org/2130293003/diff/140001/base/process/memory.h
File base/process/memory.h (right):

https://codereview.chromium.org/2130293003/diff/140001/base/process/memory.h#...
base/process/memory.h:54: const DWORD kOomExceptionCode = 0xE0000008;
A quick comment on how this is expected to be used, how it was chosen to avoid
colliding with real Windows-defined exception values and exit codes, etc.?

[Will Harris, 2016-07-19 21:22:07]

wfh@chromium.org changed reviewers:
- dcheng@chromium.org

[Will Harris, 2016-07-19 21:35:33]

thanks for reviews.

https://codereview.chromium.org/2130293003/diff/140001/base/process/memory.h
File base/process/memory.h (right):

https://codereview.chromium.org/2130293003/diff/140001/base/process/memory.h#...
base/process/memory.h:54: const DWORD kOomExceptionCode = 0xE0000008;
On 2016/07/19 20:32:08, Mark Mentovai wrote:
> A quick comment on how this is expected to be used, how it was chosen to avoid
> colliding with real Windows-defined exception values and exit codes, etc.?

Done.

[Will Harris, 2016-07-19 21:35:48]

The CQ bit was checked by wfh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 21:36:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 21:36:36]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[Mark Mentovai, 2016-07-19 21:36:38]

LGTM in base.

[Will Harris, 2016-07-19 21:37:31]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Will Harris, 2016-07-20 00:32:45]

The CQ bit was unchecked by wfh@chromium.org

[Will Harris, 2016-07-20 00:32:51]

The CQ bit was checked by wfh@chromium.org

[Will Harris, 2016-07-20 00:32:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, asvitkine@chromium.org, mtklein@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2130293003/#ps160001
(title: "comments")

[commit-bot: I haz the power, 2016-07-20 00:33:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 02:07:08]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-07-20 02:07:10]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-20 02:07:17]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 02:10:00]

Description was changed from

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Change OOMs to raise custom exception rather than breakpoint on Windows.

This adds the exception reporting for allocators in:

 - Chromium
 - Blink (both PartitionAlloc and Oilpan)
 - Skia
 - V8 (via call to new API added in crrev.com/2139873002)

Magic signature update to crash processor is in go/internal_cl_for_2130293003

BUG=614440
TEST=Visit chrome://memory-exhaust and verify that histogram
CrashExitCodes.Renderer has values in bucket 536870904.
TEST=Simulate more crashes in Chromium, Blink, V8 and Skia, and verify they all
raise exception 0xe0000008.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/8ca194a234f2ec714a46da50b2e10f2b651b9aba
Cr-Commit-Position: refs/heads/master@{#406458}
==========

[commit-bot: I haz the power, 2016-07-20 02:10:01]

Patchset 9 (id:??) landed as
https://crrev.com/8ca194a234f2ec714a46da50b2e10f2b651b9aba
Cr-Commit-Position: refs/heads/master@{#406458}