Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2130283003: Cleanup: Rename "intermediary" --> "intermediate" (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Rename "intermediary" --> "intermediate" Mechanically generated CL that does these replacements: intermediary --> intermediate intermediaries --> intermediates Intermediary --> Intermediate Intermediaries --> Intermediates Committed: https://crrev.com/ee444d779a8c4b516ee552b3e7a535c50f0a762b Cr-Commit-Position: refs/heads/master@{#404545}

Patch Set 1 #

Patch Set 2 : fix build? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4972 lines, -7755 lines) Patch
M net/cert/internal/verify_certificate_chain.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/internal/verify_certificate_chain_typed_unittest.h View 1 4 chunks +27 lines, -27 lines 0 comments Download
M net/data/cert_issuer_source_aia_unittest/generate-certs.py View 1 2 chunks +13 lines, -13 lines 0 comments Download
M net/data/cert_issuer_source_static_unittest/generate-certs.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/README View 1 1 chunk +1 line, -1 line 0 comments Download
M net/data/verify_certificate_chain_unittest/basic-constraints-pathlen-0-self-issued.pem View 1 8 chunks +213 lines, -213 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/common.py View 1 1 chunk +1 line, -1 line 0 comments Download
D net/data/verify_certificate_chain_unittest/expired-intermediary.pem View 1 1 chunk +0 lines, -280 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/expired-intermediate.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-root.pem View 1 7 chunks +157 lines, -157 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-target.pem View 1 7 chunks +157 lines, -157 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/expired-target-notBefore.pem View 1 7 chunks +157 lines, -157 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-basic-constraints-pathlen-0-self-issued.py View 1 2 chunks +10 lines, -10 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-expired-intermediary.py View 1 1 chunk +0 lines, -32 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-expired-intermediate.py View 1 2 chunks +7 lines, -7 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-root.py View 1 2 chunks +7 lines, -7 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-target.py View 1 2 chunks +7 lines, -7 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-expired-target-notBefore.py View 1 2 chunks +7 lines, -7 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-basic-constraints-ca-false.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-basic-constraints-not-critical.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-lacks-basic-constraints.py View 1 1 chunk +0 lines, -27 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-lacks-signing-key-usage.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-signed-with-md5.py View 1 1 chunk +0 lines, -27 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-unknown-critical-extension.py View 1 1 chunk +0 lines, -29 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-intermediary-unknown-non-critical-extension.py View 1 1 chunk +0 lines, -28 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-basic-constraints-ca-false.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-basic-constraints-not-critical.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-basic-constraints.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-lacks-signing-key-usage.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-signed-with-md5.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-unknown-critical-extension.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-intermediate-unknown-non-critical-extension.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-key-rollover.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-non-self-signed-root.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/generate-target-and-intermediary.py View 1 1 chunk +0 lines, -25 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/generate-target-and-intermediate.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-has-keycertsign-but-not-ca.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-has-pathlen-but-not-ca.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-not-end-entity.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-by-512bit-rsa.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-using-ecdsa.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-signed-with-md5.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-unknown-critical-extension.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-target-wrong-signature.py View 1 1 chunk +6 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-unknown-root.py View 1 2 chunks +6 lines, -6 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-violates-basic-constraints-pathlen-0.py View 1 1 chunk +11 lines, -11 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/generate-violates-pathlen-1-root.py View 1 2 chunks +8 lines, -8 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-basic-constraints-ca-false.pem View 1 1 chunk +0 lines, -281 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-basic-constraints-not-critical.pem View 1 1 chunk +0 lines, -282 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-lacks-basic-constraints.pem View 1 1 chunk +0 lines, -278 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-lacks-signing-key-usage.pem View 1 1 chunk +0 lines, -281 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-signed-with-md5.pem View 1 1 chunk +0 lines, -281 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-unknown-critical-extension.pem View 1 1 chunk +0 lines, -284 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/intermediary-unknown-non-critical-extension.pem View 1 1 chunk +0 lines, -284 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-ca-false.pem View 1 7 chunks +159 lines, -159 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-basic-constraints-not-critical.pem View 1 7 chunks +159 lines, -159 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-lacks-basic-constraints.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-lacks-signing-key-usage.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-signed-with-md5.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-unknown-critical-extension.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/intermediate-unknown-non-critical-extension.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-longrolloverchain.pem View 1 11 chunks +250 lines, -250 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-newchain.pem View 1 7 chunks +150 lines, -150 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-oldchain.pem View 1 7 chunks +150 lines, -150 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/key-rollover-rolloverchain.pem View 1 9 chunks +200 lines, -200 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/non-self-signed-root.pem View 1 7 chunks +157 lines, -157 lines 0 comments Download
D net/data/verify_certificate_chain_unittest/target-and-intermediary.pem View 1 1 chunk +0 lines, -280 lines 0 comments Download
A + net/data/verify_certificate_chain_unittest/target-and-intermediate.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-keycertsign-but-not-ca.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-has-pathlen-but-not-ca.pem View 1 7 chunks +158 lines, -158 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-not-end-entity.pem View 1 7 chunks +157 lines, -157 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-by-512bit-rsa.pem View 1 7 chunks +125 lines, -125 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-using-ecdsa.pem View 1 7 chunks +132 lines, -132 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-signed-with-md5.pem View 1 7 chunks +157 lines, -157 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-unknown-critical-extension.pem View 1 7 chunks +160 lines, -160 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/target-wrong-signature.pem View 1 6 chunks +156 lines, -156 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/unknown-root.pem View 1 5 chunks +108 lines, -108 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-basic-constraints-pathlen-0.pem View 1 7 chunks +214 lines, -214 lines 0 comments Download
M net/data/verify_certificate_chain_unittest/violates-pathlen-1-root.pem View 1 8 chunks +213 lines, -213 lines 0 comments Download
M net/net.gypi View 1 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
eroman
(I was using the wrong terminology in some earlier CLs)
4 years, 5 months ago (2016-07-08 20:45:45 UTC) #3
Ryan Sleevi
LGTM % build fixes :)
4 years, 5 months ago (2016-07-08 21:08:17 UTC) #4
eroman
updated net.gypi hopefully fixed build errors.
4 years, 5 months ago (2016-07-08 21:12:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130283003/10001
4 years, 5 months ago (2016-07-09 00:32:54 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 5 months ago (2016-07-09 00:39:14 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-09 00:39:22 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-09 00:40:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee444d779a8c4b516ee552b3e7a535c50f0a762b
Cr-Commit-Position: refs/heads/master@{#404545}

Powered by Google App Engine
This is Rietveld 408576698