Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 2130213002: cc: Do not synchronize on deletion of non-internal resources. (Closed)

Created:
4 years, 5 months ago by sunnyps
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Do not synchronize on deletion of non-internal resources. Resources which do not belong to a particular ResourceProvider should not require a WaitSyncToken. This is a speculative fix for the increased idle wakeups seen on Mac non-overlay. R=piman@chromium.org BUG=621198 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/779233fed288858ffdd15762702dd91e0f14240c Cr-Commit-Position: refs/heads/master@{#404461}

Patch Set 1 #

Patch Set 2 : cc: Do not synchronize on deletion of non-internal resources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M cc/resources/resource_provider.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
sunnyps
PTAL
4 years, 5 months ago (2016-07-08 02:32:51 UTC) #5
piman
lgtm
4 years, 5 months ago (2016-07-08 02:58:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2130213002/20001
4 years, 5 months ago (2016-07-08 19:23:43 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 19:28:31 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 19:30:55 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/779233fed288858ffdd15762702dd91e0f14240c
Cr-Commit-Position: refs/heads/master@{#404461}

Powered by Google App Engine
This is Rietveld 408576698