third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp - Issue 2130203002: [DevTools] Better ExceptionDetails in js_protocol.json

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2130203002: [DevTools] Better ExceptionDetails in js_protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js ('K') | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js ('k') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

index c2bcdab1748b4226312277d82fbb5d84dd33f6ea..b62a15321406f1c80889ccec417f0436caad9a81 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

@@ -326,10 +326,10 @@ std::unique_ptr<protocol::Runtime::ExceptionDetails> InjectedScript::createExcep

v8::Maybe<int> lineNumber = message->GetLineNumber(m_context->context());

if (lineNumber.IsJust())

- exceptionDetailsObject->setLine(lineNumber.FromJust());

+ exceptionDetailsObject->setLineNumber(lineNumber.FromJust() - 1);

v8::Maybe<int> columnNumber = message->GetStartColumn(m_context->context());

if (columnNumber.IsJust())

- exceptionDetailsObject->setColumn(columnNumber.FromJust());

+ exceptionDetailsObject->setColumnNumber(columnNumber.FromJust());

v8::Local<v8::StackTrace> stackTrace = message->GetStackTrace();

if (!stackTrace.IsEmpty() && stackTrace->GetFrameCount() > 0)