Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2130203002: [DevTools] Better ExceptionDetails in js_protocol.json (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 790 matching lines...) Expand 10 before | Expand all | Expand 10 after
801 _printResult: function(result, wasThrown, originatingConsoleMessage, excepti onDetails) 801 _printResult: function(result, wasThrown, originatingConsoleMessage, excepti onDetails)
802 { 802 {
803 if (!result) 803 if (!result)
804 return; 804 return;
805 805
806 var level = wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log; 806 var level = wasThrown ? WebInspector.ConsoleMessage.MessageLevel.Error : WebInspector.ConsoleMessage.MessageLevel.Log;
807 var message; 807 var message;
808 if (!wasThrown) 808 if (!wasThrown)
809 message = new WebInspector.ConsoleMessage(result.target(), WebInspec tor.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.Mess ageType.Result, undefined, undefined, undefined, undefined, [result]); 809 message = new WebInspector.ConsoleMessage(result.target(), WebInspec tor.ConsoleMessage.MessageSource.JS, level, "", WebInspector.ConsoleMessage.Mess ageType.Result, undefined, undefined, undefined, undefined, [result]);
810 else 810 else
811 message = new WebInspector.ConsoleMessage(result.target(), WebInspec tor.ConsoleMessage.MessageSource.JS, level, exceptionDetails.text, WebInspector. ConsoleMessage.MessageType.Result, exceptionDetails.url, exceptionDetails.line, exceptionDetails.column, undefined, [WebInspector.UIString("Uncaught"), result], exceptionDetails.stack, undefined, undefined, exceptionDetails.scriptId); 811 message = new WebInspector.ConsoleMessage(result.target(), WebInspec tor.ConsoleMessage.MessageSource.JS, level, exceptionDetails.text, WebInspector. ConsoleMessage.MessageType.Result, exceptionDetails.url, exceptionDetails.lineNu mber + 1, exceptionDetails.columnNumber + 1, undefined, [WebInspector.UIString(" Uncaught"), result], exceptionDetails.stack, undefined, undefined, exceptionDeta ils.scriptId);
812 message.setOriginatingMessage(originatingConsoleMessage); 812 message.setOriginatingMessage(originatingConsoleMessage);
813 result.target().consoleModel.addMessage(message); 813 result.target().consoleModel.addMessage(message);
814 }, 814 },
815 815
816 /** 816 /**
817 * @param {string} text 817 * @param {string} text
818 * @param {boolean} useCommandLineAPI 818 * @param {boolean} useCommandLineAPI
819 */ 819 */
820 _appendCommand: function(text, useCommandLineAPI) 820 _appendCommand: function(text, useCommandLineAPI)
821 { 821 {
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1342 return true; 1342 return true;
1343 } 1343 }
1344 return false; 1344 return false;
1345 } 1345 }
1346 } 1346 }
1347 1347
1348 /** 1348 /**
1349 * @typedef {{messageIndex: number, matchIndex: number}} 1349 * @typedef {{messageIndex: number, matchIndex: number}}
1350 */ 1350 */
1351 WebInspector.ConsoleView.RegexMatchRange; 1351 WebInspector.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698