[DevTools] Better ExceptionDetails in js_protocol.json

third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!WebInspector.JavaScriptSourceFrame} sourceFrame
  */
 WebInspector.JavaScriptCompiler = function(sourceFrame)
 {
@@ skipping 51 matching lines @@
          * @this {WebInspector.JavaScriptCompiler}
          */
         function compileCallback(target, scriptId, exceptionDetails)
         {
             this._compiling = false;
             if (this._recompileScheduled) {
                 delete this._recompileScheduled;
                 this.scheduleCompile();
                 return;
             }
-            if (!exceptionDetails)
+            if (!exceptionDetails || !Object.hasOwnProperty(exceptionDetails, "lineNumber"))
                 return;
-            this._sourceFrame.uiSourceCode().addLineMessage(WebInspector.UISourceCode.Message.Level.Error, exceptionDetails.text, exceptionDetails.line - 1, exceptionDetails.column + 1);
+            this._sourceFrame.uiSourceCode().addLineMessage(WebInspector.UISourceCode.Message.Level.Error, exceptionDetails.text, /** @type {number} */(exceptionDetails.lineNumber), exceptionDetails.columnNumber);
             this._compilationFinishedForTest();

[dgozman, 2016/07/08 20:28:19]

We should call this method even when doing early return.

[kozy, 2016/07/08 20:44:00]

Done.

[kozy, 2016/07/08 22:17:49]

Test is based on idea that this method will be called only on exception.

         }
     },
 
     _compilationFinishedForTest: function() {}
 }